Fixes #249, Fixes#514, Fixes #513; dueling FS, bracers archery #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added `?melee-damage-bonus-fns` and `?ranged-damage-bonus-fns`to damage modifier calculation
* Added checking for one-handedness to apply Dueling Fighting Style Bonus
+ Correctly applies only to melee
- TODO filter application of bonus to only one handed weapons
* Added new method `melee-damage-bonus-fn` to handle generic, conditional, damage bonuses
* Added boolean method `bow?` for checking if (long|short) bow, basically. Matches other weapon boolean checks.
* Incidental EOL change in `weapons.cljc` to LF
* Fixed Dueling style not applying +2 bonus to one handed melee weapons.
+ Properly checks for weapons in only one hand
+ Properly only applies to non-two handed melee weapons
* Commented out melee- and ranged- specific damage bonus methods. Weird front end issues occurred when `apply` was... applied to those maps plus the map for the generic `damage-bonus-fns`
* Properly utilizing the passed functions and conditions should eliminate the need for those other two methods.
* Fixed Bracers of Archery applying attack bonus instead of damage bonus
* Added new method `weapon-damage-bonus-mod` which duplicates almost all the code from `weapon-attack-bonus-mod`. Combining them may be worthwhile, using a third parameter to set which bonus we want, or even both.
codeGlaze
changed the title
datdamnzotz
added
area/application
|
In https://dev.dungeonmastersvault.com for testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes Issue #249, Fixes #513; Fixes #514; Fixes #515;
Fixed Dueling style not applying +2 bonus to one handed melee weapons.
Added
?damage-bonus-fnsto damage modifier calculationCommented out
melee-andranged-specific damage bonus methods. Weird front end issues occurred whenapplywas... applied to those maps plus the map for the genericdamage-bonus-fnsFixed Bracers of Archery applying attack bonus instead of damage bonus
weapon-damage-bonus-modwhich duplicates almost all the code fromweapon-attack-bonus-mod. Combining them may be worthwhile, using a third parameter to set which bonus we want, or even both.Added boolean method
bow?for checking if (long|short) bow, basically. Matches other weapon boolean checks.Incidental EOL change in
weapons.cljcto LFChecklist: