Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial implementation of #395 Add Background and Alignment to Edit screen #459

Merged
merged 6 commits into from
Nov 23, 2020
Merged

Partial implementation of #395 Add Background and Alignment to Edit screen #459

merged 6 commits into from
Nov 23, 2020

Conversation

datdamnzotz
Copy link

Description:

Partial implementation of #395
Add Background and Alignment to Edit screen
image

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@datdamnzotz datdamnzotz added enhancement New feature or request area/application Task related to orcpub application itself labels Sep 30, 2020
@datdamnzotz datdamnzotz self-assigned this Sep 30, 2020
@datdamnzotz
Copy link
Author

datdamnzotz commented Sep 30, 2020 •
edited
Loading

Still needs work for the "Characters" summary screen /pages/dnd/5e/characters see #395 for discussion

@datdamnzotz datdamnzotz added this to the 2.5.0.18 milestone Nov 23, 2020
@datdamnzotz datdamnzotz linked an issue Nov 23, 2020 that may be closed by this pull request
Add build number to view page #476
Closed
@datdamnzotz datdamnzotz modified the milestones: 2.5.0.18, 2.5.0.19 Nov 23, 2020
@datdamnzotz datdamnzotz linked an issue Nov 23, 2020 that may be closed by this pull request
Basic character information (Sex, Age, Height etc.) should be visible on the View page #467
Closed
@datdamnzotz datdamnzotz removed a link to an issue Nov 23, 2020
Add build number to view page #476
Closed
@datdamnzotz datdamnzotz linked an issue Nov 23, 2020 that may be closed by this pull request
Add Background and Alignment to dynamic character sheet #395
Closed
@datdamnzotz datdamnzotz merged commit 3ddc4e2 into Orcpub:develop Nov 23, 2020
@datdamnzotz datdamnzotz mentioned this pull request Dec 21, 2020
Closed
@datdamnzotz datdamnzotz deleted the #395-Add-Background-Alignment-to-dynamic-charactersheet branch April 1, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@datdamnzotz datdamnzotz

Labels
area/application Task related to orcpub application itself enhancement New feature or request
Projects
None yet
Milestone
2.5.0.19
1 participant
@datdamnzotz