Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement roll buttons to be more compact #436

Merged
merged 6 commits into from
Sep 29, 2020

Conversation

Pireax
Copy link

@Pireax Pireax commented Jul 30, 2020

Description:

Implements compact roll buttons, screenshots below of the new look:

image
image
image
image
image

Related issue (if applicable): #427

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself enhancement New feature or request labels Aug 19, 2020
@datdamnzotz datdamnzotz added this to the 2.5.0.17 milestone Aug 19, 2020
@datdamnzotz
Copy link

@Pireax could you add the buttons to ability scores as well - something like:
image
fair number of spells and contests that use raw modifiers

@Pireax
Copy link
Author

Pireax commented Aug 22, 2020

Good one, I'll take a look

Copy link

@datdamnzotz datdamnzotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on Roll buttons

@datdamnzotz datdamnzotz merged commit 8d04b60 into Orcpub:develop Sep 29, 2020
This was linked to issues Sep 30, 2020
@datdamnzotz datdamnzotz mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application Task related to orcpub application itself enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compact proficiency indicator Compact roll buttons
2 participants