Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for homebrew not being loaded. #387

Merged
merged 1 commit into from
May 6, 2020
Merged

Fix for homebrew not being loaded. #387

merged 1 commit into from
May 6, 2020

Conversation

datdamnzotz
Copy link

@datdamnzotz datdamnzotz commented May 6, 2020 •
edited
Loading

Description:

Fixes #386

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@datdamnzotz datdamnzotz added bug Something isn't working area/application Task related to orcpub application itself labels May 6, 2020
@datdamnzotz datdamnzotz added this to the 2.5.0.14 milestone May 6, 2020
@datdamnzotz datdamnzotz self-assigned this May 6, 2020
@datdamnzotz datdamnzotz merged commit 463e3b9 into Orcpub:develop May 6, 2020
@codeGlaze
Copy link

How was this working prior without the let statement?

@datdamnzotz
Copy link
Author

How was this working prior without the let statement?

It was, my fault, the ef301ec
took it out.

@codeGlaze
Copy link

Note to self: add a comment to that plugin bar so it stands out, haha.

@datdamnzotz
Copy link
Author

it was part of the google code and I didn't notice it when it took that part out ; /

@datdamnzotz datdamnzotz deleted the fix-load-homebrew branch May 7, 2020 00:49
@codeGlaze
Copy link

Nah, it was just poorly separated.

Easy mistake to make. Crazy it wasn't noticed until now. Several patrons run the Homebrew orcbrews iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeGlaze codeGlaze codeGlaze approved these changes

Assignees

@datdamnzotz datdamnzotz

Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
None yet
Milestone
2.5.0.14
Development

Successfully merging this pull request may close these issues.

Homebrew files not being loaded
2 participants
@datdamnzotz @codeGlaze