Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all expandable items clickable anywhere #414

Closed
Pireax opened this issue Jul 9, 2020 · 2 comments · Fixed by #418
Closed

Make all expandable items clickable anywhere #414

Pireax opened this issue Jul 9, 2020 · 2 comments · Fixed by #418
Labels
area/application Task related to orcpub application itself enhancement New feature or request
Milestone

Comments

@Pireax
Copy link

Pireax commented Jul 9, 2020

Motivation / Use Case
There is different behaviour for different expandable items in the user interface, some, such as spell slots expand when clicked on anywhere (screenshot 1), while other items such as in screenshot 2 require you to click the up / down arrow (which is a drag on mobile). Also the expansion arrows are touching the edge of the items in screenshot 2.

Expected Behavior
Clicking an expandable item anywhere (except on buttons etc in the item) expands the item.

Screenshots

  1. image
  2. image
@datdamnzotz
Copy link

This probably could be possible, but the Roll button is what removed that functionality. (Can't roll and expand at the same time... well probably could, but that would be weird.

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself enhancement New feature or request labels Jul 9, 2020
@Pireax
Copy link
Author

Pireax commented Jul 9, 2020

Yeah I get what you mean, what I think would make sense is that clicking anywhere on the item will expand it except when clicking on the roll / other buttons, when clicking on the roll button it should not expand but just do the 'roll' action.

Pireax added a commit to Pireax/orcpub that referenced this issue Jul 11, 2020
@datdamnzotz datdamnzotz added this to the 2.5.0.17 milestone Jul 11, 2020
datdamnzotz added a commit that referenced this issue Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application Task related to orcpub application itself enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants