Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dueling Fighting Style #249

Closed
DivertedCircle opened this issue Oct 14, 2019 · 1 comment
Closed

Dueling Fighting Style #249

DivertedCircle opened this issue Oct 14, 2019 · 1 comment
Assignees
@codeGlaze
Labels
area/application Task related to orcpub application itself bug Something isn't working
Milestone
2.5.0.21

Comments

@DivertedCircle
Copy link

DivertedCircle commented Oct 14, 2019 •
edited
Loading

Describe the bug
Dueling Fighting Style does not apply its bonus damage to one-handed weapons listed in the combat tab.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Fighter character of at least level 2.
  2. Select Dueling as your Fighting Style.
  3. Equip a one handed weapon.
  4. See damage does not increase.

Expected behavior
A +2 bonus should be applied to damage with the one handed weapon.
@cdacunha71 cdacunha71 mentioned this issue Oct 20, 2019
Closed
@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself bug Something isn't working labels Oct 23, 2019
@codeGlaze codeGlaze self-assigned this Nov 19, 2019
@datdamnzotz
Copy link

Possibly expand this to Fighting Style Creator for fighters, rangers and paladins...

@DivertedCircle DivertedCircle mentioned this issue May 4, 2020
Closed
@datdamnzotz datdamnzotz mentioned this issue Sep 30, 2020
Closed
codeGlaze added a commit to codeGlaze/orcpub that referenced this issue Feb 28, 2021
@codeGlaze
Fixes Issue Orcpub#249, Fixes Orcpub#514;
8a7ccce 
* Fixed Dueling style not applying +2 bonus to one handed melee weapons.
    + Properly checks for weapons in only one hand
    + Properly only applies to non-two handed melee weapons

* Commented out melee- and ranged- specific damage bonus methods. Weird front end issues occurred when `apply` was... applied to those maps plus the map for the generic `damage-bonus-fns`
    * Properly utilizing the passed functions and conditions should eliminate the need for those other two methods.

* Fixed Bracers of Archery applying attack bonus instead of damage bonus
    * Added new method `weapon-damage-bonus-mod` which duplicates almost all the code from `weapon-attack-bonus-mod`. Combining them may be worthwhile, using a third parameter to set which bonus we want, or even both.
@codeGlaze codeGlaze mentioned this issue Feb 28, 2021
Merged
5 tasks
@datdamnzotz datdamnzotz added this to the 2.5.0.21 milestone Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeGlaze codeGlaze

Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
None yet
Milestone
2.5.0.21
Development

No branches or pull requests
3 participants
@datdamnzotz @codeGlaze @DivertedCircle