Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 [Feature Request]: upgrade polkadot-sdk to v1.13.0 #205

Closed
3 tasks done
4meta5 opened this issue May 26, 2024 · 9 comments · Fixed by #298
Closed
3 tasks done

🎁 [Feature Request]: upgrade polkadot-sdk to v1.13.0 #205

4meta5 opened this issue May 26, 2024 · 9 comments · Fixed by #298
Assignees
Labels
enhancement New feature or request priority: 2 We will resolve this in a short timeframe.

Comments

@4meta5
Copy link
Contributor

4meta5 commented May 26, 2024

templates

  • Generic Runtime Template
  • Evm Template

What is the feature you would like to see?

  1. choose polkadot-sdk version to upgrade before/until higher priority issues are done. v1.12.0 was released 5 days ago as of writing this
  2. upgrade all forks required for external dependencies
  3. document and iteratively automate all processes

(1) requires beforehand agreement as a group to choose the stable version. The work required for (2) will determine timing and prioritization of (1).

It may not be ideal to be the first to upgrade all the dependencies i.e. frontier as well as any additional external dep forks required to finish #189 i.e. ORML, Acala, Moonbeam, HydraDX

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@4meta5 4meta5 added enhancement New feature or request priority: 0 Nice-to-have. Willing to ship without this. labels May 26, 2024
@4meta5 4meta5 added this to the Future Steps milestone May 26, 2024
@ozgunozerk
Copy link
Collaborator

We have a specific issue for the 3rd point made for this issue. Better to dump all info we gathered on update process there #93

@4meta5
Copy link
Contributor Author

4meta5 commented May 27, 2024

We have a specific issue for the 3rd point made for this issue. Better to dump all info we gathered on update process there #93

Cool, my hope is that whoever takes this issue would do work on #93 as part of the process even if they don't necessarily finish #93

@ozgunozerk ozgunozerk self-assigned this May 27, 2024
@4meta5 4meta5 assigned 4meta5 and unassigned ozgunozerk Aug 6, 2024
@4meta5 4meta5 moved this from 🗒 Backlog to 🏗 In Development in Substrate Runtime Templates Aug 6, 2024
@4meta5 4meta5 changed the title 🎁 [Feature Request]: upgrade polkadot-sdk to v1.12.0(+) 🎁 [Feature Request]: upgrade polkadot-sdk to v1.11.0 Aug 6, 2024
@4meta5
Copy link
Contributor Author

4meta5 commented Aug 6, 2024

Assigned myself and set the upgrade version as discussed in our meeting today.

@4meta5 4meta5 mentioned this issue Aug 6, 2024
2 tasks
@ggonzalez94
Copy link
Collaborator

@4meta5 moving this to Milestone 3 since you are already working on it

@4meta5 4meta5 assigned ozgunozerk and unassigned 4meta5 Aug 10, 2024
@4meta5 4meta5 changed the title 🎁 [Feature Request]: upgrade polkadot-sdk to v1.11.0 🎁 [Feature Request]: upgrade polkadot-sdk to v1.13.0 Aug 15, 2024
@4meta5 4meta5 self-assigned this Aug 15, 2024
@4meta5
Copy link
Contributor Author

4meta5 commented Aug 15, 2024

Reassigned myself because I upgraded the forks for Moonbeam and ORML.

@ozgunozerk the forked crates that we use (pallet-asset-manager, xcm-primitives) are compiling with the updated dependencies:

@4meta5 4meta5 added priority: 2 We will resolve this in a short timeframe. and removed priority: 0 Nice-to-have. Willing to ship without this. labels Aug 15, 2024
@4meta5
Copy link
Contributor Author

4meta5 commented Aug 20, 2024

replaced by #294 @ozgunozerk @ggonzalez94 why did this task require opening a new issue vs updating this issue's title

@ozgunozerk
Copy link
Collaborator

ozgunozerk commented Aug 20, 2024

the other issue is not a replacement. No need to close this one. The PR addressing the update will close both of them.
We previously planned to upgrade to v1.13.0 and every single one of us contributed to this task.

After that, Nikita suggested we upgrade to even newer version, and I opened a new issue for that, which doesn't neglect this one.

Edit: the reason I opened a new issue instead of updating this one is: that we mentioned this also in the meeting, updating dependencies is not an easy task, and with this one, we updated 5 big versions.

The initial plan was to upgrade to v1.13.0, then after I'm done with the upgrade, with Nikita's suggestion, we decided to upgrade to stable2407-1, basically doubling the workload. Chunking a huge task into 2 smaller issues isn't something new for this repo.
There are currently 2 separate branches (one for v1.13.0 and one for stable2407-1), if you want to review them in a more granular fashion, I can submit 2 PRs instead of a single one

@ozgunozerk ozgunozerk reopened this Aug 20, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🗒 Backlog in Substrate Runtime Templates Aug 20, 2024
@ozgunozerk
Copy link
Collaborator

Assigned also @KitHat since he contributed to evm-node part and fuzzer

@4meta5
Copy link
Contributor Author

4meta5 commented Aug 20, 2024

The PR addressing the update will close both of them.

This is/was the issue for whatever version we update to...I still do not see any response to my suggestion to just update the title for this issue.

Regardless the other issue's upgrade builds off of the work done for this upgrade so contributions should carry over.

@4meta5 4meta5 moved this from 🗒 Backlog to 🏗 In Development in Substrate Runtime Templates Aug 20, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Development to ✅ Done in Substrate Runtime Templates Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment