ASTDereferencerError: No node with id -18 of type FunctionDefinition

[StackOverflowExcept1on]

Code of our Solidity project for some reason doesn't pass some checks in your library. Could you please check why? Our code successfully passes the build with solc, but not your AST validation.

ref OpenZeppelin/openzeppelin-foundry-upgrades#93

[FAIL: revert: Failed to run upgrade safety validation: /root/.npm/_npx/e9c2fe9985ed1095/node_modules/solidity-ast/dist/ast-dereferencer.js:73
        throw new ASTDereferencerError(id, nodeType);
              ^

ASTDereferencerError: No node with id -18 of type FunctionDefinition
    at deref (/root/.npm/_npx/e9c2fe9985ed1095/node_modules/solidity-ast/dist/ast-dereferencer.js:73:15)
    at derefNode (/root/.npm/_npx/e9c2fe9985ed1095/node_modules/solidity-ast/dist/ast-dereferencer.js:76:16)
    at curried (/root/.npm/_npx/e9c2fe9985ed1095/node_modules/solidity-ast/dist/ast-dereferencer.js:86:20)
    at getRecursiveFunctionIds (/root/.npm/_npx/e9c2fe9985ed1095/node_modules/@openzeppelin/upgrades-core/dist/validate/run/initializer.js:214:16)
    at getInitializerCallExceptions (/root/.npm/_npx/e9c2fe9985ed1095/node_modules/@openzeppelin/upgrades-core/dist/validate/run/initializer.js:130:40)
    at getInitializerCallExceptions.next (<anonymous>)
    at getInitializerExceptions (/root/.npm/_npx/e9c2fe9985ed1095/node_modules/@openzeppelin/upgrades-core/dist/validate/run/initializer.js:37:20)
    at getInitializerExceptions.next (<anonymous>)
    at validate (/root/.npm/_npx/e9c2fe9985ed1095/node_modules/@openzeppelin/upgrades-core/dist/validate/run.js:138:67)
    at runValidations (/root/.npm/_npx/e9c2fe9985ed1095/node_modules/@openzeppelin/upgrades-core/dist/cli/validate/validations.js:22:41) {
  id: -18,
  nodeType: [ 'FunctionDefinition' ]
}

[ericglau]

@StackOverflowExcept1on Thanks for reporting. I am working on a fix but would like to test it out. Would it be possible for you to share a repository or contracts that encounter this issue?

[StackOverflowExcept1on]

@ericglau OpenZeppelin/openzeppelin-foundry-upgrades#93
https://github.com/gear-tech/gear/tree/master/ethexe/contracts

[ckartik]

We're encountering this issue as well in our CI. @ericglau

https://github.com/primev/mev-commit

[ericglau]

Fixed in @openzeppelin/[email protected]