From 4cc856585001c8c436728bd325dc93f18a44f449 Mon Sep 17 00:00:00 2001 From: Ross Campbell <41117279+Ro5s@users.noreply.github.com> Date: Wed, 10 Mar 2021 16:21:20 -0500 Subject: [PATCH 1/3] Update draft-IERC20Permit.sol minor conforming changes to comments --- contracts/token/ERC20/extensions/draft-IERC20Permit.sol | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contracts/token/ERC20/extensions/draft-IERC20Permit.sol b/contracts/token/ERC20/extensions/draft-IERC20Permit.sol index dac94af447a..dd83f7f1ed7 100644 --- a/contracts/token/ERC20/extensions/draft-IERC20Permit.sol +++ b/contracts/token/ERC20/extensions/draft-IERC20Permit.sol @@ -7,7 +7,7 @@ pragma solidity ^0.8.0; * https://eips.ethereum.org/EIPS/eip-2612[EIP-2612]. * * Adds the {permit} method, which can be used to change an account's ERC20 allowance (see {IERC20-allowance}) by - * presenting a message signed by the account. By not relying on `{IERC20-approve}`, the token holder account doesn't + * presenting a message signed by the account. By not relying on {IERC20-approve}, the token holder account doesn't * need to send a transaction, and thus is not required to hold Ether at all. */ interface IERC20Permit { @@ -26,7 +26,7 @@ interface IERC20Permit { * - `deadline` must be a timestamp in the future. * - `v`, `r` and `s` must be a valid `secp256k1` signature from `owner` * over the EIP712-formatted function arguments. - * - the signature must use ``owner``'s current nonce (see {nonces}). + * - the signature must use `owner`'s current nonce (see {nonces}). * * For more information on the signature format, see the * https://eips.ethereum.org/EIPS/eip-2612#specification[relevant EIP @@ -38,13 +38,13 @@ interface IERC20Permit { * @dev Returns the current nonce for `owner`. This value must be * included whenever a signature is generated for {permit}. * - * Every successful call to {permit} increases ``owner``'s nonce by one. This + * Every successful call to {permit} increases `owner`'s nonce by one. This * prevents a signature from being used multiple times. */ function nonces(address owner) external view returns (uint256); /** - * @dev Returns the domain separator used in the encoding of the signature for `permit`, as defined by {EIP712}. + * @dev Returns the domain separator used in the encoding of the signature for {permit}, as defined by {EIP712}. */ // solhint-disable-next-line func-name-mixedcase function DOMAIN_SEPARATOR() external view returns (bytes32); From eb44f44318c7dbec77676663a3d620e89e826214 Mon Sep 17 00:00:00 2001 From: Francisco Giordano Date: Wed, 10 Mar 2021 19:41:33 -0300 Subject: [PATCH 2/3] add back double backticks --- contracts/token/ERC20/extensions/draft-IERC20Permit.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contracts/token/ERC20/extensions/draft-IERC20Permit.sol b/contracts/token/ERC20/extensions/draft-IERC20Permit.sol index dd83f7f1ed7..4624fb044d3 100644 --- a/contracts/token/ERC20/extensions/draft-IERC20Permit.sol +++ b/contracts/token/ERC20/extensions/draft-IERC20Permit.sol @@ -12,7 +12,7 @@ pragma solidity ^0.8.0; */ interface IERC20Permit { /** - * @dev Sets `value` as the allowance of `spender` over `owner`'s tokens, + * @dev Sets `value` as the allowance of `spender` over ``owner``'s tokens, * given `owner`'s signed approval. * * IMPORTANT: The same issues {IERC20-approve} has related to transaction @@ -38,7 +38,7 @@ interface IERC20Permit { * @dev Returns the current nonce for `owner`. This value must be * included whenever a signature is generated for {permit}. * - * Every successful call to {permit} increases `owner`'s nonce by one. This + * Every successful call to {permit} increases ``owner``'s nonce by one. This * prevents a signature from being used multiple times. */ function nonces(address owner) external view returns (uint256); From e89b11bf547059ce330bd664d8ba230e7b4e8650 Mon Sep 17 00:00:00 2001 From: Francisco Giordano Date: Wed, 10 Mar 2021 19:44:49 -0300 Subject: [PATCH 3/3] add back double backticks --- contracts/token/ERC20/extensions/draft-IERC20Permit.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contracts/token/ERC20/extensions/draft-IERC20Permit.sol b/contracts/token/ERC20/extensions/draft-IERC20Permit.sol index 4624fb044d3..1a8731a5879 100644 --- a/contracts/token/ERC20/extensions/draft-IERC20Permit.sol +++ b/contracts/token/ERC20/extensions/draft-IERC20Permit.sol @@ -13,7 +13,7 @@ pragma solidity ^0.8.0; interface IERC20Permit { /** * @dev Sets `value` as the allowance of `spender` over ``owner``'s tokens, - * given `owner`'s signed approval. + * given ``owner``'s signed approval. * * IMPORTANT: The same issues {IERC20-approve} has related to transaction * ordering also apply here. @@ -26,7 +26,7 @@ interface IERC20Permit { * - `deadline` must be a timestamp in the future. * - `v`, `r` and `s` must be a valid `secp256k1` signature from `owner` * over the EIP712-formatted function arguments. - * - the signature must use `owner`'s current nonce (see {nonces}). + * - the signature must use ``owner``'s current nonce (see {nonces}). * * For more information on the signature format, see the * https://eips.ethereum.org/EIPS/eip-2612#specification[relevant EIP