Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract interfaces are named "upgradable" even if not relevant #149

Closed
fulldecent opened this issue Mar 5, 2022 · 2 comments
Closed

Contract interfaces are named "upgradable" even if not relevant #149

fulldecent opened this issue Mar 5, 2022 · 2 comments

Comments

@fulldecent
Copy link
Contributor

fulldecent commented Mar 5, 2022 •
edited
Loading

I believe the contract interface IERC721Upgradeable is identical to baseline IERC721 in OpenZeppelin Contracts.

This file and contract interface could please be renamed to just IERC721 to indicate that no new additional functionality is claimed over the baseline specification.

Likewise for other similar interfaces.
@frangio
Copy link
Contributor

frangio commented Mar 7, 2022

Duplicate of OpenZeppelin/openzeppelin-contracts#3928.

This is a breaking change that we're likely implementing in the next major release.

@frangio frangio closed this as completed Mar 7, 2022
@fulldecent
Copy link
Contributor Author

Sorry for the dupe, nice thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fulldecent @frangio