Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual721 tests fail in cairo v2.1.1 #702

Closed
andrew-fleming opened this issue Aug 18, 2023 · 1 comment · Fixed by #703
Closed

Dual721 tests fail in cairo v2.1.1 #702

andrew-fleming opened this issue Aug 18, 2023 · 1 comment · Fixed by #703
Assignees
@andrew-fleming

Comments

@andrew-fleming
Copy link
Collaborator

andrew-fleming commented Aug 18, 2023 •
edited
Loading

When deploying the dual721 contracts in tests, the caller needs to be set with set_contract_address (in place of set_caller_address) in Cairo v2.1.1. Otherwise, some of the dual721 tests fail. This occurs because the caller address passed to _mint in the constructor is 0. The dual721 mocks are the only mocks that use get_caller_address in the constructor; hence, these are the only tests that are failing
@andrew-fleming andrew-fleming mentioned this issue Aug 18, 2023
Merged
@martriay martriay added this to the current milestone Aug 22, 2023
@martriay martriay moved this to 🏗 In progress in Contracts for Cairo Aug 22, 2023
@martriay martriay linked a pull request Aug 22, 2023 that will close this issue
Bump scarb and fix dual721 test context #703
Merged
@martriay martriay moved this from 🏗 In progress to 👀 In review in Contracts for Cairo Aug 22, 2023
@andrew-fleming
Copy link
Collaborator Author

The change in the cairo repo occurred here: starkware-libs/cairo@15fb40e (included in the update to cairo v2.1.1)

@martriay martriay moved this from 👀 In review to ✅ Resolved in Contracts for Cairo Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-fleming andrew-fleming

Labels
None yet
Projects
Contracts for Cairo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump scarb and fix dual721 test context andrew-fleming/cairo-contracts
2 participants
@martriay @andrew-fleming