Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings storage seems to be ambiguous #43

Closed
emphasize opened this issue Feb 5, 2023 · 3 comments
Closed

settings storage seems to be ambiguous #43

emphasize opened this issue Feb 5, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@emphasize
Copy link
Member

even though the ocp plugin uses XDG_CONFIG_HOME for its settings (.config/mycroft/apps/ovos.common_play/settings.json), sometimes it tries to save into the package library

21:56:52.501 - audio - ovos_utils.skills.settings:save_settings:118 - ERROR - error saving skill settings to /usr/lib/python3.10/site-packages/ovos_plugin_common_play/ocp/settings.json
@JarbasAl
Copy link
Member

JarbasAl commented Feb 5, 2023

the xdg path was a recent change in last release, the OVOSAbstractApp and OVOSSkill classes have been unified in workshop, at same time OCP was refactored to follow a standard with all apps, perhaps some issue was introduced here

@JarbasAl JarbasAl added the bug Something isn't working label Feb 5, 2023
@JarbasAl JarbasAl self-assigned this Feb 5, 2023
@emphasize
Copy link
Member Author

emphasize commented Feb 6, 2023

And there is more to it. After i changed app_view_timeout_enabled in the GUI menu, the config was written just fine. GUI wasn't reacting to the changes (ie not returning to the homescreen in timeout seconds) and i switched between pause and all. i went back and the setting was an empty dict.

Anything i can test?

@emphasize
Copy link
Member Author

Goes way back. don't think this is still an issue.

@github-actions github-actions bot mentioned this issue Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants