Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services don't start with malformed configuration #97

Closed
builderjer opened this issue Jan 15, 2024 · 2 comments
Closed

Services don't start with malformed configuration #97

builderjer opened this issue Jan 15, 2024 · 2 comments

Comments

@builderjer
Copy link
Member

I have come across the issue when /etc/mycroft/mycroft.conf is malformed, ovos-messagebus will not start.

expected

Since there is a default config file provided with core, I would expect a warning that this could not be loaded, and skipped instead of creating an error

The file at ~/.config/mycroft/mycroft.conf is already handled this way.

@JarbasAl
Copy link
Member

we account for user mistakes, but that file is meant for distros and it being invalid really should be breaking IMHO

you dont want to silence that error or hide it, want to fail loudly so the image maintainers ensure they ship a valid config

@builderjer
Copy link
Member Author

I agree and will close this

@builderjer builderjer closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
@github-actions github-actions bot mentioned this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants