From e22caf082abd17a3dfed7d3e71a2e9b74e28b15f Mon Sep 17 00:00:00 2001 From: JarbasAI <33701864+JarbasAl@users.noreply.github.com> Date: Tue, 1 Aug 2023 14:57:49 +0100 Subject: [PATCH 1/2] debug logs on message emit failure --- ovos_bus_client/client/client.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ovos_bus_client/client/client.py b/ovos_bus_client/client/client.py index cd6b21d..9266019 100644 --- a/ovos_bus_client/client/client.py +++ b/ovos_bus_client/client/client.py @@ -167,12 +167,15 @@ def emit(self, message: Message): try: if hasattr(message, 'serialize'): - self.client.send(message.serialize()) + msg = message.serialize() else: - self.client.send(json.dumps(message.__dict__)) + msg = json.dumps(message.__dict__) + self.client.send(msg) except WebSocketConnectionClosedException: - LOG.warning('Could not send %s message because connection ' - 'has been closed', message.msg_type) + LOG.warning(f'Could not send {message.msg_type} message because connection ' + 'has been closed') + except Exception as e: + LOG.exception(f"failed to emit message {message.msg_type}") def collect_responses(self, message: Message, min_timeout: Union[int, float] = 0.2, From 78ff317d4e7234ba0ef3810dc5e433e8ad46336d Mon Sep 17 00:00:00 2001 From: JarbasAI <33701864+JarbasAl@users.noreply.github.com> Date: Tue, 1 Aug 2023 15:28:02 +0100 Subject: [PATCH 2/2] len of emitted message --- ovos_bus_client/client/client.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ovos_bus_client/client/client.py b/ovos_bus_client/client/client.py index 9266019..bfc0578 100644 --- a/ovos_bus_client/client/client.py +++ b/ovos_bus_client/client/client.py @@ -165,17 +165,17 @@ def emit(self, message: Message): 'before emitting messages') self.connected_event.wait() + if hasattr(message, 'serialize'): + msg = message.serialize() + else: + msg = json.dumps(message.__dict__) try: - if hasattr(message, 'serialize'): - msg = message.serialize() - else: - msg = json.dumps(message.__dict__) self.client.send(msg) except WebSocketConnectionClosedException: LOG.warning(f'Could not send {message.msg_type} message because connection ' 'has been closed') except Exception as e: - LOG.exception(f"failed to emit message {message.msg_type}") + LOG.exception(f"failed to emit message {message.msg_type} with len {len(msg)}") def collect_responses(self, message: Message, min_timeout: Union[int, float] = 0.2,