Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Support Email Attachments #12

Open
NeonDaniel opened this issue Oct 4, 2022 · 0 comments
Open

Support Email Attachments #12

NeonDaniel opened this issue Oct 4, 2022 · 0 comments
Assignees

Comments

@NeonDaniel
Copy link
Member

NeonDaniel commented Oct 4, 2022

Email attachments should be (optionally) supported for backends (like Neon) that can handle them. Default behavior will need to be defined if a backend doesn't support attachments.. Some possibilities:

  • Raise an exception
  • Log an exception and send the email with no attachments
  • Try appending attachment contents as text to the email body (warn/fail on binary files)

def send_email(self, title, body, sender):

In Neon:
https://github.com/NeonGeckoCom/neon-skill-utils/blob/dev/neon_utils/skills/neon_skill.py#L314-L329

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants