ABI and BIN provider now uses contracts from BrandedTokenContracts npm #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xsarvesh
requested review from
schemar,
benjaminbollen,
abhayks1 and
gulshanvasnani
schemar
approved these changes
Mar 7, 2019
| }, | ||
| Staker: Staker, | ||
| Facilitator: Facilitator, |
There was a problem hiding this comment.
Suggested change
| Facilitator: Facilitator, | |
| Facilitator, |
| }, | ||
| Staker: Staker, |
There was a problem hiding this comment.
Suggested change
| Staker: Staker, | |
| Staker, |
| ); | ||
| } | ||
|
|
||
| contract.bin = contractBin; |
There was a problem hiding this comment.
You could probably refactor the addABI and addBIN methods to call on something like addCustom('abi', contractName, contractAbi) (similar for bin).
| @@ -31,7 +31,8 @@ const config = require('../../utils/configReader'); | |||
| const shared = require('../shared'); | |||
|
|
|||
| const { GatewayComposerHelper } = Package.EconomySetup; | |||
| const { Staker, StakeHelper } = Package.Helpers; | |||
| const { StakeHelper } = Package.Helpers; | |||
| const { Staker } = Package; | |||
There was a problem hiding this comment.
Is it on purpose that the tests import "Package" and not the modules directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
ABI BIN provider now uses BrandedTokenContract NPM.
Noticeable changes:
addABIandaddBINfunction.