Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branded-token.js now exposes mosaic.js contract interacts #114

Merged
merged 6 commits into from
Mar 7, 2019
Merged

branded-token.js now exposes mosaic.js contract interacts #114

merged 6 commits into from
Mar 7, 2019

Conversation

0xsarvesh
Copy link
Contributor

Fixes #111

Exposing mosaic.js contract interacts.

@0xsarvesh 0xsarvesh self-assigned this Mar 6, 2019
schemar
schemar previously approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Should we consider "namespacing" the mosaic contract interacts below BrandedToken.ContractInteract.Mosaic?

index.js Outdated Show resolved Hide resolved
@0xsarvesh
Copy link
Contributor Author

0xsarvesh commented Mar 7, 2019 •
edited
Loading

LGTM :shipit:

Should we consider "namespacing" the mosaic contract interacts below BrandedToken.ContractInteract.Mosaic?

I am not sure.
But what's the value for the consumer in having the mosaic namespace?
In my opinion, it should be abstracted.

schemar
schemar approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️:shipit:

@schemar schemar merged commit 0913846 into OpenST:develop Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schemar schemar schemar approved these changes

@hobofan hobofan Awaiting requested review from hobofan

@benjaminbollen benjaminbollen Awaiting requested review from benjaminbollen

@abhayks1 abhayks1 Awaiting requested review from abhayks1

Assignees

@0xsarvesh 0xsarvesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xsarvesh @schemar