Changing Network settings from Template default doesn't apply settings during VM instantiation

[TreZc0]

Description
In a freshly deployed ON (set up on 5.12.0.1 CE), instantiating a VM based on a template with a default network selected will cause this VM to always be created in this network, even if a different network (and IP address) was applied.

To Reproduce

1. Create two different virtual networks
2. Create a template with a default network
3. Instantiate VM and change the network to use to the one not in the template. Optional: Define a custom IP address within the range of this network.

Expected behavior
The VM is created with an IP lease from the network defined during instantiation, not the default. The Force IPv4 field is taken into account and the VM is created with an virtual network interface holding the provided IP.
(Actual Behavior:) Instead, it is created within the default network of the base template. The custom IP address is not applied.

Details

• Affected Component: Sunstone
• Hypervisor: KVM
• Version: 5.12.0.2

Additional context
The instance was created on 5.12.0.1 and was updated to 5.12.0.2 this morning. The issue existed on 5.12.0.1 as well. A third network was created for testing purposes, same result. Creating a separate template with the desired network and instantiating a VM off that template works for the network, but custom IP addresses are still not applied.

Progress Status

• Branch created
• Code committed to development branch
• Testing - QA
• Documentation
• Release notes - resolved issues, compatibility, known issues
• Code committed to upstream release/hotfix branches
• Documentation committed to upstream release/hotfix branches

[TreZc0]

Related? #4409
Was this ported back to 5.12.0.2?

[tinova]

#4409 was included 5.12.0 CE

[TreZc0]

Not related then I imagine. It seems consistent though.

[TreZc0]

After diving deeper, it seems the bug i found is related to this:
#5061

Any specific reason why this wasn't cherry picked for 5.12.0.3? Or was it just forgotten unfortunately?

[FrederickBor]

Can't reproduce this issue in one-6.2 or one-5.12