Make one Event to change currency format.

[JesperHerrloff]

Today, we have to utilize 2 separate events:

currency_display_options_forming and catalog_product_view_config With just the first one the changes are made until product_options.js messes al up :) With the second one you can override priceFormat and fix it.

But in a ideal world it would be more logical to have an event after locale is loaded to make changes easier.

Maybe its only me and my clients that are needing extreme customisations :D

Updated to Openmage from Magento 1.9 in the last weekend :D It was a lot of surprises ;) To find out how many core hacks that where made to make all work for my client. But thats on me as a developer for beeing lazy :)

[kiatng]

Can you provide some examples of currency formats that you need to change? Do you use the currency switcher?

[JesperHerrloff]

Yes For example 100 000 SEK
10 000 EUR
Zero decimals and no dots or commas as thousand dividers. I know I can probably hack the core and use number_format, but I feel like that would be the wrong solution.

Yes we have 2 currencies, so the currency switcher is used.

[kiatng]

Is it number formatting in general? Or only for currency?

[JesperHerrloff]

Only for currencies and prices. Had ET_CurrencyManager before, but it become messy in openmage.
And if I check Zend Currency If the price format is so prices become for example 100(NBSP)000 and you set the currency format to other than Zend_Currency::STANDARD it will remove the space and messes things up :)

https://github.com/Shardj/zf1-future/blob/master/library/Zend/Currency.php#L200

One possibility would be to make some composer magic to override this file, but I am not sure about consequenses of that.

A better way in my opinion would be to use some setting for currency formatting per store or something like that. Will dig into this later and find a way to do it without breaking the core.

[sreichel]

One possibility would be to make some composer magic to override this file, but I am not sure about consequenses of that.

As a temporary fix you can patch Zend_Currency ... see https://docs.openmage.org/blog/2023/08/17/customize-your-openmage/#symplifyvendor-patches