Missing descriptions on hover for elements and features in server.xml (Windows)

[dessina-devasia]

During the FVT testing of liberty-tools version 24.0.3-SNAPSHOT on a Windows 11 environment, I encountered an issue where the documentation for any elements or feature descriptions within the server.xml file could not be found.

For reference, I've attached a screenshot below showcasing the absence of documentation within the server.xml file.

[mrglavas]

I think this may have been exposed by the performance issue we're investigating with LCLS: #687, but seems the root cause might be in LSP4iJ. I think I found where textDocument/hover is supported: https://github.com/MicroShed/lsp4ij/blob/main/src/main/java/org/microshed/lsp4ij/operations/documentation/LSPTextHoverForFile.java and can see there's a short time-out. I wonder if this could be improved similarly to what was recently done for quick fixes where it actually waits for the response and will work even if the server is slow.

[angelozerr]

I improved in our lsp4ij the hover and now it should work without timeout.

Since your last update I did a lot of refactoring break some api etc.

I suggest you really to be based on our lsp4ij

[TrevCraw]

PR here should mitigate this issue until we are able to move to a newer version of lsp4ij: MicroShed/lsp4ij#14

[TrevCraw]

Review if LSP4IJ updates from April 1st contain the complete fix for this problem. Test the behaviour to verify the fix.

[mrglavas]

I've confirmed that this issue has been resolved by the upgrade to LSP4iJ 2024/04/01. Hover now displays "Fetching Documentation..." while waiting for the response and then displays the documentation for the feature once the response has been returned and processed. The class LSPTextHoverForFile.java which had been patched to mitigate this issue no longer exists.