Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liberty Dashboard still detects Gradle project when plugin is commented #445

Closed
evie-lau opened this issue Jun 12, 2023 · 2 comments
Closed
Labels
bug Something isn't working nice-to-fix
Milestone

Comments

@evie-lau
Copy link
Member

When the plugin definition for Liberty Gradle Tools io.openliberty.tools.gradle.Liberty is commented, the Liberty dashboard still detects the project.
image

May be due to the regex used to detect the plugin definition.

Could rework the regex, or preferably programmatically read the plugin IDs to check for it instead, if possible.

@dshimo
Copy link
Contributor

dshimo commented Jun 12, 2023

Seems like the negative lookbehind for comments simply didn't work.

@turkeylurkey
Copy link
Member

If you want to stick with negative lookbehind then "(?<!//\s*)" should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nice-to-fix
Projects
Development

No branches or pull requests

4 participants