Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion should maybe incorporate full feature element contents looking for version error #180

Closed
scottkurz opened this issue Jun 9, 2023 · 2 comments
Assignees
Labels
LemMinX Liberty extension to Eclipse Lemminx

Comments

@scottkurz
Copy link
Member

Using the recent 1.0-SNAPSHOT, if I type <feature>restConnector-1.0</feature>and have the cursor after the '0', the feature suggestions seem to only include the "1.0" as context and completely ignores the "restConnector" part.

image

The correct feature is restConnector-2.0.

Should LCLS try to make a suggestion from the perspective of "right feature name but wrong version"??

@cherylking cherylking added the LemMinX Liberty extension to Eclipse Lemminx label Jun 9, 2023
@cherylking
Copy link
Member

After changing the completion code to inspect what was passed in for the feature name, and only returning features that start with or contain the first part of the feature name (before the version number), the list displayed in Liberty Tools for Visual Studio Code still did not include useful entries. The IDEs themselves seem to have some logic that is doing the fuzzy matching.

I did take this opportunity though to prototype adding a quick fix for the diagnostic. Here are a couple of screenshots of what that would look like. I think this is a good work around and may even be better. What do you think @scottkurz ?

Screenshot 2023-09-08 at 1 40 44 PM

Screenshot 2023-09-08 at 1 40 33 PM

Here is a more interesting one where only part of the feature name was entered:

Screenshot 2023-09-08 at 1 39 10 PM

Screenshot 2023-09-08 at 1 39 25 PM

@cherylking
Copy link
Member

With the PRs that I merged, I am considering this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LemMinX Liberty extension to Eclipse Lemminx
Projects
Status: 23.0.12
Development

No branches or pull requests

2 participants