diff --git a/.github/ISSUE_TEMPLATE/bug.yml b/.github/ISSUE_TEMPLATE/bug.yml index f3e79e2..9262a3b 100644 --- a/.github/ISSUE_TEMPLATE/bug.yml +++ b/.github/ISSUE_TEMPLATE/bug.yml @@ -9,7 +9,7 @@ body: Thank you for taking the time to fill out this bug report! ⚠️ If the bug that you are reporting is a security-related issue or security vulnerability, - then please do not create a report via this template. Instead please + then please do not create a report via this template. Instead please notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/) or directly via email to [AWS Security](aws-security@amazon.com). @@ -54,9 +54,9 @@ body: description: Please provide information on the environment and software versions that you are using to reproduce the bug. value: | At minimum: - 1. Operating system: (e.g. Windows Server 2022; Amazon Linux 2023; etc.) - 2. Output of `python3 --version`: - 3. Version of this library. + 1. Operating system (e.g. Windows Server 2022; Amazon Linux 2023; etc.) + 2. Output of `python3 --version` + 3. Version of this library Please share other details about your environment that you think might be relevant to reproducing the bug. validations: diff --git a/.github/ISSUE_TEMPLATE/doc.yml b/.github/ISSUE_TEMPLATE/doc.yml index 7a95fad..cdde690 100644 --- a/.github/ISSUE_TEMPLATE/doc.yml +++ b/.github/ISSUE_TEMPLATE/doc.yml @@ -2,7 +2,7 @@ name: "📕 Documentation Issue" description: Issue in the documentation title: "Docs: (short description of the issue)" -labels: ["documenation", "needs triage"] +labels: ["documentation", "needs triage"] body: - type: textarea id: documentation_issue diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index d284468..d644b5f 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -1,7 +1,7 @@ name: "\U0001F680 Feature Request" description: Request a new feature title: "Feature request: (short description of the feature)" -labels: ["feature", "needs triage"] +labels: ["enhancement", "needs triage"] body: - type: textarea id: problem diff --git a/.github/ISSUE_TEMPLATE/maintenance.yml b/.github/ISSUE_TEMPLATE/maintenance.yml index f2440eb..e95acbf 100644 --- a/.github/ISSUE_TEMPLATE/maintenance.yml +++ b/.github/ISSUE_TEMPLATE/maintenance.yml @@ -1,7 +1,7 @@ name: "🛠️ Maintenance" description: Some type of improvement title: "Maintenance: (short description of the issue)" -labels: ["feature", "needs triage"] +labels: ["maintenance", "needs triage"] body: - type: textarea id: description diff --git a/requirements-development.txt b/requirements-development.txt index 2d27088..5997871 100644 --- a/requirements-development.txt +++ b/requirements-development.txt @@ -1,2 +1,2 @@ -hatch == 1.13.* +hatch == 1.14.* hatch-vcs == 0.4.* \ No newline at end of file diff --git a/requirements-release.txt b/requirements-release.txt index c49048b..3c2e488 100644 --- a/requirements-release.txt +++ b/requirements-release.txt @@ -1 +1 @@ -python-semantic-release == 9.14.* \ No newline at end of file +python-semantic-release == 9.20.* \ No newline at end of file diff --git a/src/openjd/adaptor_runtime/_background/frontend_runner.py b/src/openjd/adaptor_runtime/_background/frontend_runner.py index e47d4dc..d9bd864 100644 --- a/src/openjd/adaptor_runtime/_background/frontend_runner.py +++ b/src/openjd/adaptor_runtime/_background/frontend_runner.py @@ -149,7 +149,7 @@ def init( ) args.extend(["--bootstrap-log-file", bootstrap_log_path]) - _logger.debug(f"Running process with args: {args}") + _logger.info(f"Running process with args: {args}") bootstrap_output_path = os.path.join( bootstrap_log_dir, f"adaptor-runtime-background-bootstrap-output-{bootstrap_id}.log" ) diff --git a/test/openjd/adaptor_runtime/integ/test_integration_entrypoint.py b/test/openjd/adaptor_runtime/integ/test_integration_entrypoint.py index d1690ff..0218c7e 100644 --- a/test/openjd/adaptor_runtime/integ/test_integration_entrypoint.py +++ b/test/openjd/adaptor_runtime/integ/test_integration_entrypoint.py @@ -112,8 +112,8 @@ def test_start_stop(self, caplog: pytest.LogCaptureFixture, tmp_path: Path): assert "Connected successfully" in caplog.text assert "Running in background daemon mode." in caplog.text assert "Daemon background process stopped." in caplog.text - assert "on_prerun" not in caplog.text - assert "on_postrun" not in caplog.text + assert "on_prerun" in caplog.text + assert "on_postrun" in caplog.text def test_run(self, caplog: pytest.LogCaptureFixture, tmp_path: Path): # GIVEN diff --git a/test/openjd/adaptor_runtime/unit/background/test_frontend_runner.py b/test/openjd/adaptor_runtime/unit/background/test_frontend_runner.py index 0bb19e8..64736f0 100644 --- a/test/openjd/adaptor_runtime/unit/background/test_frontend_runner.py +++ b/test/openjd/adaptor_runtime/unit/background/test_frontend_runner.py @@ -219,6 +219,34 @@ def test_initializes_backend_process( ) mock_heartbeat.assert_called_once() + def test_arguments_to_daemon_serve_are_logged_at_info_level( + self, + mock_path_exists: MagicMock, + mock_Popen: MagicMock, + caplog: pytest.LogCaptureFixture, + ): + # GIVEN + caplog.set_level("INFO") + mock_path_exists.return_value = False + adaptor_module = ModuleType("") + adaptor_module.__package__ = "package" + conn_file_path = Path("/path") + runner = FrontendRunner() + + # WHEN + runner.init( + adaptor_module=adaptor_module, + connection_file_path=conn_file_path, + ) + + # THEN + assert any( + "Running process with args" in captured_message + for captured_message in caplog.messages + ) + mock_path_exists.assert_called_once_with() + mock_Popen.assert_called_once() + def test_raises_when_adaptor_module_not_package(self): # GIVEN adaptor_module = ModuleType("")