ci: Simplify build_llvm.bash script #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove leftover logic from when we used TravisCI. * Pick a default for LLVM_DISTRO_NAME so it works when the script is run standalone when not on GitHub Actions CI. (But it's still really only meant to run on x86 Ubuntu, and not designed for anything useful outside of our CI. * Eliminate all the complexity with old LLVM versions -- in practice, our CI only uses this to download fairly modern clang versions. Fixes 3891 Signed-off-by: Larry Gritz <[email protected]>
|
N.B.: The broken tests are entirely unrelated to this change and have been occurring on the nightly CI builds for a couple days, apparently linked to a dependency repo change. I have reported the problem and hope it is fixed soon. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 1, 2023
* Remove leftover logic from when we used TravisCI. * Pick a default for LLVM_DISTRO_NAME so it works when the script is run standalone when not on GitHub Actions CI. (But it's still really only meant to run on x86 Ubuntu, and not designed for anything useful outside of our CI.) * Eliminate all the complexity with old LLVM versions -- in practice, our CI only uses this to download fairly modern clang versions. Fixes AcademySoftwareFoundation#3891 Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3891