Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issues on JDK 14 #652

Closed
sheinbergon opened this issue Apr 8, 2020 · 8 comments
Closed

Compatibility issues on JDK 14 #652

sheinbergon opened this issue Apr 8, 2020 · 8 comments

Comments

@sheinbergon
Copy link

Hi

sun.nio.ch.FileChannelImpl.map0 implementation has changed on JDK 14, requiring an additional boolean param.

This makes CQ unusable on that version of the JDK (works fine on JDK 13).

Tested with CQ version 5.19.2

@dpisklov
Copy link
Contributor

dpisklov commented Apr 9, 2020

@sheinbergon Chronicle's JDK support policy is linked to LTS versions. We support Java 8 and Java 11. So far, Oracle hasn't announced any LTS versions past Java 11 so we do not intend to support newer versions until there is an LTS version.
That said, we are happy to accept PRs.

@sheinbergon
Copy link
Author

@dpisklov Thank you for your response.
Next LTS version would be JDK 17 ( a year and half from now).
When that version arrives, you're going to meet that error I just mentioned.

I'll see if it's complicated to fix it myself or not and let you know.

@sheinbergon
Copy link
Author

@dpisklov Opened this PR to provide initial support for JDK 14, tested locally and seems to be fine.

@sheinbergon
Copy link
Author

@dpisklov any response?

@dpisklov
Copy link
Contributor

dpisklov commented Apr 14, 2020

@sheinbergon sorry it was a bank holiday in the UK.
I merged the PR.

@dpisklov
Copy link
Contributor

@sheinbergon can we close this?

@sheinbergon
Copy link
Author

@dpisklov any chance to release a new version for the Chronicle-Core and this project pointing to the aforementioned with that fix merged?

10x

@dpisklov
Copy link
Contributor

@sheinbergon
Done.

Chronicle-BOM : 2.19.116

chronicle-core: 2.19.4

chronicle-queue: 5.19.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants