Coin sorter V2 corrected with tests #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kochebina I integrated the data but the tests are failling. For example: |
|
Hello @tbaudier, I removed the old tests that are failing. Sorry for this oversight. Cheers,
|
|
Salut Thomas,
Si on revient sur le 10 et le CoinSorter: il faut retirer de tests les
anciens tests:
test072_coinc_sorter_step2_config1removeMultiples.py : failed
test072_coinc_sorter_step2_config2minDistanceXY.py : failed
test072_coinc_sorter_step2_config2takeWinnerIfIsGood.py : failed
Je l'ai fait dans mon PR mais il faut les retirer des tests qu'on passe
sinon le PR passera jamais :-)
Et encore une fois je ne sais pas comment le faire et même si j'ai les
droits...
A+
Olga
Le ven. 20 déc. 2024 à 11:10, tbaudier ***@***.***> a écrit :
… Hello @kochebina <https://github.com/kochebina>
I integrated the data but the tests are failling. For example:
(venv) (base) ***@***.*** src % python test072_coinc_sorter_2keep_all.py
Opening /Users/tbaudier/Software/GatePython/opengate/opengate/tests/output/test072_coinc_sorter/test72_output_1.root ...
There are 7685 singles
{'EventID': 'int32_t', 'PostPosition_X': 'double', 'PostPosition_Y': 'double', 'PostPosition_Z': 'double', 'TotalEnergyDeposit': 'double', 'PreStepUniqueVolumeID': 'char*', 'GlobalTime': 'double'}
Traceback (most recent call last):
File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 69, in <module>
main()
File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 48, in main
coincidences = coincidences_sorter(
TypeError: coincidences_sorter() missing 1 required positional argument: 'maxDistanceZ'
—
Reply to this email directly, view it on GitHub
<#652 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKBSL7MWTZHAWCTNHRHU4VD2GPUKNAVCNFSM6AAAAABT5OVKN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJWGY4DINRTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
For commit d091b94 |
gertvanhoey
reviewed
Feb 5, 2025
opengate/actors/coincidences.py
Outdated
|
|
||
| if abs(time - time_window_open) <= time_window: | ||
|
|
||
| # remove if in the same volume | ||
| # Remove if in the same volume | ||
| if ( | ||
| singles[i]["PreStepUniqueVolumeID"] | ||
| == singles[j]["PreStepUniqueVolumeID"] | ||
| ): | ||
| break |
There was a problem hiding this comment.
@kochebina I wonder if this should be continue instead of break, because break finishes the inner loop in j and in this way, other coincidences in the same time window might be skipped.
There was a problem hiding this comment.
Good point! Thank you @gertvanhoey
|
test085 are failing dur to modification of the data in that PR: #685 |
tbaudier
force-pushed
the
CoinSorter_v2
branch
from
3f27567 to
1e894f8
Compare
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tbaudier @nkrah @dsarrut
I don't know what happened to the prev. PR for CoinSorter... but here it the new one.
The corrected version of it is in this PR.
It is ready!
The ref data to be copied to opengate/tests/data/output_ref/test072 is here:
https://doi.org/10.6084/m9.figshare.28063244.v1