Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Add suggested mapping & refactor content tab (#5651)(#6803) #7262

Merged
merged 39 commits into from
Jun 27, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Jun 6, 2024

Proposed changes

  • Refactor content tab =>Add content mapping and suggested mapping view
  • Add suggested mapping actions

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@marieflorescontact marieflorescontact self-assigned this Jun 6, 2024
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Jun 6, 2024
@marieflorescontact marieflorescontact changed the title Issue/5651 chunk3 Issue/5651 Refactor content tab (#5651) Jun 7, 2024
@marieflorescontact marieflorescontact force-pushed the issue/5651-chunk3 branch 2 times, most recently from 7d584d2 to fda376d Compare June 11, 2024 05:35
@labo-flg
Copy link
Member

Closes #7430
Am I right @JeremyCloarec ?

@SamuelHassine SamuelHassine force-pushed the master branch 3 times, most recently from b710111 to c15ed81 Compare June 23, 2024 20:06
@marieflorescontact marieflorescontact changed the title Issue/5651 Refactor content tab (#5651) [backend/frontend] Add suggested mapping and refactor content tab (#5651)(#6803) Jun 26, 2024
@marieflorescontact marieflorescontact changed the title [backend/frontend] Add suggested mapping and refactor content tab (#5651)(#6803) [backend/frontend] Add suggested mapping & refactor content tab (#5651)(#6803) Jun 26, 2024
@JeremyCloarec JeremyCloarec marked this pull request as ready for review June 26, 2024 09:45
`;

/* const clearSuggestedMappingMutation = graphql`
mutation ContainerSuggestedMappingContentClearSuggestedMappingMutation(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it ?

$references: [String]
) {
stixCoreObjectEdit(id: $id) {
relationsAdd(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use FieldPatch along with mappingContent to send only one mutation instead of two

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.41%. Comparing base (06e8c93) to head (b3af1cc).
Report is 6 commits behind head on master.

Files Patch % Lines
...tform/opencti-graphql/src/domain/stixCoreObject.js 7.69% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7262      +/-   ##
==========================================
+ Coverage   67.34%   67.41%   +0.06%     
==========================================
  Files         563      563              
  Lines       69680    69712      +32     
  Branches     5891     6018     +127     
==========================================
+ Hits        46928    46994      +66     
+ Misses      22752    22718      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact merged commit 3d38ae1 into master Jun 27, 2024
5 checks passed
@marieflorescontact marieflorescontact deleted the issue/5651-chunk3 branch June 27, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Content tab of containers, when selecting "main content", it is displayed "No file selected" on the bottom
5 participants