Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] All Prediction features: When a non-price value is the target column, the table output is incorrectly assumed as a price. #2085

Closed
deeleeramone opened this issue Jul 13, 2022 · 1 comment · Fixed by #1933
Assignees
Labels
bug Bugs and bug fixes

Comments

@deeleeramone
Copy link
Contributor

The tables that are printed from prediction menu features incorrectly assumes everything is a price. This causes rounding to occur where it shouldn't in the raw tables output by all features in this menu.

The $ is also not located in the correct position. $1.00, not, 1.00 $

Screen Shot 2022-07-13 at 10 53 20 AM

Screen Shot 2022-07-13 at 10 52 38 AM

Screen Shot 2022-07-13 at 10 58 52 AM

Screen Shot 2022-07-13 at 10 57 53 AM

Target Column: Returns
Screen Shot 2022-07-13 at 10 59 42 AM

@github-actions github-actions bot added the bug Bugs and bug fixes label Jul 13, 2022
@jmaslek
Copy link
Contributor

jmaslek commented Jul 14, 2022

This may be upgraded on @martinb-bb 's new menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants