Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject in pending state #1941

Closed
RomuDeuxfois opened this issue Nov 27, 2024 · 10 comments
Closed

Inject in pending state #1941

RomuDeuxfois opened this issue Nov 27, 2024 · 10 comments
Assignees
Labels
bug use for describing something not working as expected solved The issue has been solved

Comments

@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Nov 27, 2024

Description

We still have some inject in pending state:

@RomuDeuxfois RomuDeuxfois added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Nov 27, 2024
@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Nov 27, 2024
@EllynBsc EllynBsc added this to the Bugs backlog milestone Nov 27, 2024
@isselparra
Copy link
Contributor

isselparra commented Nov 28, 2024

Analysis (so far)

Basic Permission Groups Discovery Windows (Domain)
I executed this Payload as an Atomic Testing twice and there seems no problem here (status MAYBE_PREVENTED)
https://testing.obas.staging.filigran.io/admin/atomic_testings/40c27754-5f86-49ea-a523-fd11c89db972
https://testing.obas.staging.filigran.io/admin/atomic_testings/05916618-b8c9-4574-a15e-0e5bf66dc7ba

I lanched two simulations with this Payload and two other ones from the original simulation

The attack command seems quite simple

net localgroup
net group /domain
net group "enterprise admins" /domain
net group "domain admins" /domain

System Information Discovery
I executed this Payload as an Atomic Testing twice and both have the INJECT_EXECUTED status so no problem here
https://testing.obas.staging.filigran.io/admin/atomic_testings/e513d745-24d5-4ab5-b72b-65301f51e942
https://testing.obas.staging.filigran.io/admin/atomic_testings/0f468d53-53c0-4177-bb8f-475b73873d67

I lanched two simulations with this Payload and two other ones from the original simulation

The attack command seems simple

systeminfo
reg query HKLM\SYSTEM\CurrentControlSet\Services\Disk\Enum

@RomuDeuxfois
Copy link
Member Author

Can you create a simulation with these two injects which have the same trigger date?
Maybe this is because the two injects are played at the same time.

@isselparra isselparra self-assigned this Nov 28, 2024
@isselparra
Copy link
Contributor

I launched a simulation with these two payloads:

Both were processed:

  • Basic Permission Groups Discovery Windows (Domain) => Status MAYBE_PREVENTED
  • System Information Discovery => Status INJECT_EXECUTED

@isselparra
Copy link
Contributor

Same result after both Injects launched at the same time, two minutes later

https://testing.obas.staging.filigran.io/admin/simulations/307ebde3-0d96-4777-8877-97ed12e5078c

Both were processed:
Basic Permission Groups Discovery Windows (Domain) => Status MAYBE_PREVENTED
System Information Discovery => Status INJECT_EXECUTED

@isselparra
Copy link
Contributor

isselparra commented Nov 28, 2024

Even when we have a Simulation with a few Injects, an Inject could still be on pending or on draft

For example:
I created a Simulation with three Injects

  • Basic Permission Groups Discovery Windows (Domain)
  • Basic Permission Groups Discovery Windows (Local)
  • Windows - Delete Volume Shadow Copies via WMI with PowerShell

Execution 1:
This Simulation is still on going since there is an Inject still on draft
https://testing.obas.staging.filigran.io/admin/simulations/5bdb4a93-c61d-4025-986e-3ea561cf3824

  • Basic Permission Groups Discovery Windows (Domain) => Status MAYBE_PREVENTED
  • Basic Permission Groups Discovery Windows (Local) => Status INJECT_EXECUTED
  • Windows - Delete Volume Shadow Copies via WMI with PowerShell => Status DRAFT

Execution 2:
The Simulation is now FINISHED
Note that the Inject Windows - Delete Volume Shadow Copies via WMI with PowerShell took 30 minutes longer to be executed compared with the other two Injects
https://testing.obas.staging.filigran.io/admin/simulations/27e41da9-ee5f-4fca-b563-15d6a5ca4661

  • Basic Permission Groups Discovery Windows (Domain) => Status MAYBE_PREVENTED
  • Basic Permission Groups Discovery Windows (Local) => Status INJECT_EXECUTED
  • Windows - Delete Volume Shadow Copies via WMI with PowerShell => Status INJECT_EXECUTED

We may have an idempotence problem: even if we launch two Simulations with the same Injects, we are not sure that we are going to obtain the same results.

We need to analyse more deeply the issue we are seeing with these Injects.

@RomuDeuxfois
Copy link
Member Author

For the pending inject, I think the problem come from the implant.
If the implant has fail to report result, the inject status still in PENDING.
We should have a garbage collector to handle this case (with a timeout).

@EllynBsc
Copy link
Member

Hello @RomuDeuxfois @isselparra 👋

What's the status of this issue ? Is it on pause ?

@RomuDeuxfois
Copy link
Member Author

We were waiting for developments on the implant side.
Now that they have been done, we can resume investigating this bug.

@damgouj damgouj self-assigned this Jan 10, 2025
@damgouj
Copy link
Member

damgouj commented Jan 10, 2025

The 2 first payloads work thanks to other issues (the "MAYBE_PREVENTED" one is because we have some restrictions when we try to discover the domain)
Image
Image
Image

The last payload "Data Encrypt Using DiskCryptor" is "PARTIAL" because it executes a background process and has no response. It will be fixed with the issue #1860
Image

@damgouj damgouj closed this as completed Jan 10, 2025
@damgouj damgouj added the solved The issue has been solved label Jan 10, 2025
@EllynBsc
Copy link
Member

Thank you @damgouj for the follow up! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved The issue has been solved
Projects
None yet
Development

No branches or pull requests

5 participants