Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slave Node will coredump if if conf item "max-rsync-parallel-num" is greater than 4 #2594

Closed
cheniujh opened this issue Apr 15, 2024 · 0 comments · Fixed by #2595
Closed
Labels
☢️ Bug Something isn't working

Comments

@cheniujh
Copy link
Collaborator

Is this a regression?

No

Description

当pika.conf中的max-rsync-parallel-num大于4,slave会在主从复制时coredump。
在slave的rsync client内,固定预留4个waitObject,每个WorkerThread使用一个,如果pika.conf中的该值大于4(WorkerThread数量),WaitObject数组会越界。
另外在master的rsync server内,每个rsyncServerConn也是固定预留4个fileReader, 所以 max-rsync-parallel-num 值域为[1,4]。

解决:
完善参数检查,当max-rsync-parallel-num值非法,自动reset为4

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

image

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☢️ Bug Something isn't working
Projects
None yet
1 participant