Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][JAVA] Dependencies missing for some Java libraries / configs #20073

Closed
2 of 6 tasks
DielN opened this issue Nov 9, 2024 · 0 comments · Fixed by #20075
Closed
2 of 6 tasks

[BUG][JAVA] Dependencies missing for some Java libraries / configs #20073

DielN opened this issue Nov 9, 2024 · 0 comments · Fixed by #20075

Comments

@DielN
Copy link
Contributor

DielN commented Nov 9, 2024

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

In #20011 we noticed that a lot of the Java libraries using the useReflectionEqualsHashCode config are missing the commons-lang3 dependency in their pom template. I also noticed the mutiny dependency missing in one of the poms for the microprofile library.

openapi-generator version

7.9.0

Steps to reproduce

e.g. update the java-feign sample with useReflectionEqualsHashCode: true, regenerate samples and run mvn integration-test -f samples/client/petstore/java/feign/pom.xml

Suggest a fix

The missing dependencies should be added to the pom templates and the samples should be updated/added so this is covered in the future. It might also be worth looking for more such cases of dependencies missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant