Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation step for restarting a finished job #287

Open
m-mohr opened this issue Mar 24, 2022 · 3 comments
Open

Add confirmation step for restarting a finished job #287

m-mohr opened this issue Mar 24, 2022 · 3 comments

Comments

@m-mohr
Copy link
Member

m-mohr commented Mar 24, 2022

When restarting a finished job, old results usually get discarded. This is a single method execution without confirmation. We should ensure people don't do this by accident and ask for confirmation.

Origin: Open-EO/openeo-api#442

@danielFlemstrom
Copy link

danielFlemstrom commented Mar 30, 2022

I actually think the same goes for cancelled.

How about the following when receiving a start request on a finished or cancelled job:

  1. A finished/cancelled job goes to created (which in practice means that you need to start it again, as confirmation)
    If you wish to add a confirmation pop-up, ask for the job status before.
  2. Only remove old results when going from queued to running

@soxofaan
Copy link
Member

I don't understand what you mean @danielFlemstrom

A finished/cancelled job goes to created

when? Automatically? or do you mean when restarting? But then you have to send the "start" request twice?

Only remove old results when going from queued to running

the "queued" state is an optional state (some back-ends might go from "created" to "running" immediately)

@danielFlemstrom
Copy link

I updated my previous comment about when to change status. However, thinking it over, it was an misunderstanding from my side. Ignore the comment for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants