Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filters #104

Closed
m-mohr opened this issue Dec 13, 2019 · 3 comments
Closed

Fix filters #104

m-mohr opened this issue Dec 13, 2019 · 3 comments
Labels
bug help wanted Extra attention is needed
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Dec 13, 2019

Currently, the property filters (e.g. filter or properties in load_collection) is completely broken as there's no way to properly reference the metadata fields and also the type "boolean" for expression elements doesn't really reflect that you can insert processes returning a boolean.

How I could imagine it working in the future: #84 (comment)

@m-mohr m-mohr added this to the v1.0 milestone Dec 13, 2019
@m-mohr m-mohr added bug help wanted Extra attention is needed labels Dec 13, 2019
@lforesta
Copy link
Contributor

the property filters (e.g. filter or properties in load_collection)

"filter" here is the process filter? I thought this process does not work on metadata but on pixel values?

@m-mohr
Copy link
Member Author

m-mohr commented Dec 16, 2019

filter (and filter_*) are working on dimension labels, not pixel values.
The parameter properties in load_collection is working on metadata.
I haven't made this clear in the initial post. Anyway, there's no way to reference the dimension labels/metadata fields, which is an issue at the moment.

@m-mohr
Copy link
Member Author

m-mohr commented Dec 19, 2019

Closing as duplicate of #84

@m-mohr m-mohr closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants