Ios11 startup crash fix #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Crash was due to a bad pointer getting the supper class of the last entry from objc_getClassList
* The 2nd call can sometimes result in the last entry in the array not being initialized fully
on iOS 11 if more classes are still being loaded into memory.
jkasten2
force-pushed
the
ios11_startup_crash_fix
branch
from
78ba0ed to
b1adc0a
Compare
philipphofmann
added a commit
to getsentry/sentry-cocoa
that referenced
this pull request
Oct 15, 2021
Calling class_getSuperclass sometimes leads to EXC_I386_GPFLT. OneSignal had the same issue OneSignal/OneSignal-iOS-SDK#278 and it was fixed with OneSignal/OneSignal-iOS-SDK#301. This PR applies the changes they did to our code to fix the problem. Fixes GH-1395
5 tasks
philipphofmann
added a commit
to getsentry/sentry-cocoa
that referenced
this pull request
Oct 18, 2021
Calling class_getSuperclass sometimes leads to EXC_I386_GPFLT. OneSignal had the same issue OneSignal/OneSignal-iOS-SDK#278 and it was fixed with OneSignal/OneSignal-iOS-SDK#301. This PR applies the changes they did to our code to fix the problem. Fixes GH-1395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a startup an intermittent startup crash on class_getSuperclass.
Re-based history , commit with testing with pointer range check.
12a2a7a
This change is