Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES - Multiple build flavors use the same Google OAuth credentials #852

Closed
barbeau opened this issue Feb 5, 2018 · 0 comments · Fixed by #1049
Closed

ES - Multiple build flavors use the same Google OAuth credentials #852

barbeau opened this issue Feb 5, 2018 · 0 comments · Fixed by #1049
Assignees
Labels
Milestone

Comments

@barbeau
Copy link
Member

barbeau commented Feb 5, 2018

Summary:

If you install more than one build flavor of OBA (e.g., obaGoogle and obaAgencyX), and then try to log in with embedded social, you get prompted to associate the login with more than one application. I believe this is due to the hard-coded value com.joulespersecond.seattlebusbot for package_name in onebusaway-android/google-services.json. This should be dynamically changed to reflect the applicationId defined in build.gradle. For example, for Agency X it should be org.agencyx.android.

Screenshot:

image

Related to #853, as to fully support independent ES profiles per build flavor, each build flavor also needs it's own Embedded Social API key.

Steps to reproduce:

  1. Install both the obaGoogle and obaAgencyX build flavors
  2. Open obaGoogle (i.e., normal) OBA app
  3. Go to navigation drawer and tap "Log in"
  4. Tap "Google"

Expected behavior:

Take me straight to the Google OAuth screen on behalf of the normal OBA app

Observed behavior:

It gives me the option to handle the action using either the normal OBA app or the Agency X app

Device and Android version:

Samsung Galaxy S8+ w/ Android 8.0 beta

Screenshots:

See above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants