Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tasks.json tasks #3145

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Modify tasks.json tasks #3145

merged 2 commits into from
Jul 1, 2019

Conversation

akshita31
Copy link
Contributor

Modified the tasks that are provided in the default tasks.json to:

  1. Use msCompile as the problem matcher
  2. GenerateFullPaths as msCompile expects full paths(Errors in output window do not get source links #1197)
  3. Do not produce summary as that is leading to duplicate errors in the problem window(Errors are duplicated in output window #1198)

@akshita31
Copy link
Contributor Author

cc @nguerrera

@akshita31
Copy link
Contributor Author

microsoft/vscode#76318

This is the PR in vscode where the build templates are present that are put up when we do Ctrl+Shift+B.

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7b2bf9b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3145   +/-   ##
=========================================
  Coverage          ?   89.79%           
=========================================
  Files             ?       59           
  Lines             ?     1588           
  Branches          ?       89           
=========================================
  Hits              ?     1426           
  Misses            ?      151           
  Partials          ?       11
Flag Coverage Δ
#integration 100% <ø> (?)
#unit 89.79% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2bf9b...df8581e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #3145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3145   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          59       59           
  Lines        1590     1590           
  Branches       89       89           
=======================================
  Hits         1428     1428           
  Misses        151      151           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2bf9b...df8581e. Read the comment docs.

@akshita31 akshita31 merged commit 8c1a0f2 into dotnet:master Jul 1, 2019
@akshita31 akshita31 deleted the taskTemplates branch July 1, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants