Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building the project #837

Closed
ofer987 opened this issue Apr 7, 2023 · 2 comments
Closed

Building the project #837

ofer987 opened this issue Apr 7, 2023 · 2 comments

Comments

@ofer987
Copy link
Contributor

ofer987 commented Apr 7, 2023

Hi,

Maybe this question has been asked before, but would you have any instructions for how I can build omnisharp-vim manually on my computer?

I would like to add some functionality such as GotoTypeDefinition, but I would like to do it the right way, by adding tests to util.py. But I cannot find any instructions for how to build the Python project.

Thank you,
-Dan

@nickspoons
Copy link
Member

Hi @ofer987, good idea to add a GotoTypeDefinition endpoint, that'll be useful, after it was added to omnisharp-roslyn last year (OmniSharp/omnisharp-roslyn#2315).

This project doesn't need to be built. Both vimscript and python are interpreted, there is no compile step.

But more importantly, the python we have is essentially obsolete. A few years ago we added the omnisharp-vim stdio integration with the server, as an improvement and simplification to our previous http integration. The http integration uses python for server communication but the stdio integration doesn't: it is pure vimscript and is much faster and more robust.

Since then, a lot of new functionality like test runners and semantic highlighting have only been added to the stdio integration.

So my recommendation would be to ignore the python/http integration entirely and simply add functionality to the stdio side.

@ofer987
Copy link
Contributor Author

ofer987 commented Apr 8, 2023

Thanks @nickspoons.

I have just opened a PR at #838 to add an OmniSharpGotoTypeDefinition command.

Would you please review?

@ofer987 ofer987 closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants