Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoding of .NET version from the .NET 6 publish #2294

Open
333fred opened this issue Dec 4, 2021 · 0 comments
Open

Remove hardcoding of .NET version from the .NET 6 publish #2294

333fred opened this issue Dec 4, 2021 · 0 comments

Comments

@333fred
Copy link
Contributor

333fred commented Dec 4, 2021

Currently we're including -net6.0 in our publish urls for OmniSharp. This is bad because we cannot programmatically determine, from a client, whether .NET 6 is the current version of OmniSharp, and we have to hardcode the net6.0 part. This will then require a rev of the extension every time we want to update the .NET version, which is brittle. We should do one of two things:

  1. Update the URL to not include a version number. Something like just -net, for example, though that does seem a bit odd (if this is the .NET version, what's the other one exactly?).
  2. Update the latest version info we publish to include the version of .NET it uses, and also include that info in the blob storage we publish for an individual release, so that clients can programmatically ask for that info, then construct the correct download URLs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants