Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements #1147

Open
rchande opened this issue Apr 6, 2018 · 1 comment
Open

Logging improvements #1147

rchande opened this issue Apr 6, 2018 · 1 comment

Comments

@rchande
Copy link

rchande commented Apr 6, 2018

The OmniSharp logs in dotnet/vscode-csharp#2147 don't make it easy to figure out what's going wrong. In that bug, a user has opened a directory containing a netcoreapp2.0 project that's been restored. For some reason, every file is full of errors that basically indicate that OmniSharp was unable to load reference assemblies.

The logs indicate:

  • Omnisharp located a project and successfulled parsed it and determined the TFM
  • The /codecheck endpoint find lots of diagnostics due to missing reference assemblies.

By looking at the logs, we aren't able to determine:

  • What paths the MSBuild project loader considered for reference assemblies
  • What MetadataReferences were added to the OmniSharp workspace

We should add this additional logging to help diagnose issues like dotnet/vscode-csharp#2147

@rchande
Copy link
Author

rchande commented Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant