Skip to content

Commit 4edc6ad

Browse files
iBotPeachesOlimpiaZurek
authored andcommitted
build: remove deprecated File.exists() method from Hermes podspec. (facebook#35853)
Summary: Remove deprecated `File.exists` method which was removed in later Ruby versions. Spotted during a brew upgrade [here](software-mansion/react-native-reanimated#3919). https://rubyapi.org/2.5/o/file#method-c-exist-3F ``` Fetching podspec for `hermes-engine` from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec` [!] Failed to load 'hermes-engine' podspec: [!] Invalid `hermes-engine.podspec` file: undefined method `exists?' for File:Class. # from [..]/node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec:46 ``` ## Changelog [IOS] [FIXED] - Migrated `File.exists` from Hermes podspec for non-deprecated `File.exist`. Pull Request resolved: facebook#35853 Test Plan: Valid CI via CircleCI. Reviewed By: dmytrorykun Differential Revision: D42543148 Pulled By: cipolleschi fbshipit-source-id: 5ed30d8cc3e4c91a6e86d51f7d44a125bf85f7e8
1 parent 8e049e4 commit 4edc6ad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sdks/hermes-engine/hermes-utils.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def compute_hermes_source(build_from_source, hermestag_file, git, version, build
3636
if ENV.has_key?('HERMES_ENGINE_TARBALL_PATH')
3737
use_tarball(source)
3838
elsif build_from_source
39-
if File.exists?(hermestag_file)
39+
if File.exist?(hermestag_file)
4040
build_from_tagfile(source, git, hermestag_file)
4141
else
4242
build_hermes_from_source(source, git)

0 commit comments

Comments
 (0)