Fabric 7 example-app-base cleanup #9272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
requested review from
aditima,
dzearing,
evlevy,
jordandrako,
kenotron,
KevinTCoughlin,
khmakoto,
Raghurk and
a team
as code owners
|
Component perf results:
|
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Remove some deprecated components from example-app-base, fix some of the most obvious styling issues in demo apps and the website, and other cleanup.
Highlights of the other cleanup:
Make demo app creator work with nested nav links (so now the DetailsList examples can be listed as sub-links under DetailsList)
Make generated codepens load
office-ui-fabric-react@betainstead of current. (This has the side effect of breaking export to codepen in the legacy and date-time packages, so I removed the codepen links from those examples. It's probably something we could fix later, just needs more thought/time.)(We still need to do a full styling pass on the website and ideally also the demo apps before releasing Fabric 7.)
Focus areas to test
Microsoft Reviewers: Open in CodeFlow