Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate stop-on-error #8467

Merged
merged 6 commits into from
Apr 21, 2023
Merged

fix: validate stop-on-error #8467

merged 6 commits into from
Apr 21, 2023

Conversation

nliu-ms
Copy link
Contributor

@nliu-ms nliu-ms commented Apr 20, 2023

VSCode:

Stop-on-error in provisioning:
image

Continue if only warnings exist:
image

For non-lifecycle command:
image

CLI:

Stop-on-error in provisioning:
image

Continue if only warnings exist:
image

image

For non-lifecycle command:
image

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #8467 (d30e472) into dev (fa76a51) will increase coverage by 0.01%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8467      +/-   ##
==========================================
+ Coverage   78.63%   78.65%   +0.01%     
==========================================
  Files         606      606              
  Lines       41838    41853      +15     
  Branches     8321     8326       +5     
==========================================
+ Hits        32901    32919      +18     
- Misses       5599     5601       +2     
+ Partials     3338     3333       -5     
Impacted Files Coverage Δ
...rc/component/driver/teamsApp/validateAppPackage.ts 83.87% <83.33%> (+1.97%) ⬆️

... and 9 files with indirect coverage changes

@nliu-ms nliu-ms marked this pull request as ready for review April 21, 2023 02:16
@nliu-ms nliu-ms merged commit 369be92 into dev Apr 21, 2023
@wenytang-ms wenytang-ms deleted the nliu/stop-on-error branch May 10, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants