Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin ssd1306_oled_display #1173

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Add plugin ssd1306_oled_display #1173

merged 1 commit into from
Mar 26, 2023

Conversation

fredrikbaberg
Copy link
Contributor

No description provided.

jneilliii
jneilliii approved these changes Mar 26, 2023
View reviewed changes
Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good. nice rewrite of the forked plugin. one thing I thought I would note, you could utilize self._settings.get_int(["width"]), etc. to have those auto-convert the type for you.

@jneilliii jneilliii merged commit 65886e1 into OctoPrint:gh-pages Mar 26, 2023
@fredrikbaberg
Copy link
Contributor Author

Thank you. I'll look into get_int.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneilliii jneilliii jneilliii approved these changes

Assignees
No one assigned
Labels
needs review
Projects
OctoPrint Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikbaberg @jneilliii