Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin InfluxDB2 #1163

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Added plugin InfluxDB2 #1163

merged 2 commits into from
Mar 5, 2023

Conversation

MoltenBytes
Copy link
Contributor

Here's the link to the new plugin

Not sure what else I can say that hasn't already been said in these documents or back on the homepage 😅

Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see one change that I would request prior to merging this into the plugin repo. Your plugin is missing a software update hook, which would allow for your users to automatically get update notifications on new releases. You can find the docs for this here. I can't say I remember another GitLab example of this but will try to find one for you.

@jneilliii
Copy link
Contributor

The only other GitLab example of a plugin update I could find actually utilizes PyPi release updates. I'm sure there's a way to do it similar to the GitHub version without PyPi releases, just don't have an example for you.

https://gitlab.com/wolframmfg/octoprint-swapxy/-/blob/main/octoprint_swapxy/__init__.py#L17

@MoltenBytes
Copy link
Contributor Author

I think I got it -- gitlab doesn't have native support, but I was able to make it work with git ls-remote on a command line. A few things to note:

  • It might be good to support git ls-remote as a ubiquitous option for any git server
  • The docs you linked to say that you can use the command_line check, but digging through the source it's actually commandline

If you want to test it, you can install the package from v0.1.2 here and it should prompt and successfully update to v0.1.3
https://gitlab.com/moltenbytes32/octoprint-influxdb2/-/archive/v0.1.2/octoprint-influxdb2-v0.1.2.zip

@jneilliii
Copy link
Contributor

Test worked as expected, only downside to the commandline update method though means os compatibility needs to be flagged now to linux only in your plugin template.

@jneilliii
Copy link
Contributor

I remembered where I've seen GitLab update before. It was with my palette and it's related plugins.

https://gitlab.com/mosaic-mfg/palette-2-plugin/-/blob/master/octoprint_palette2/__init__.py

@MoltenBytes
Copy link
Contributor Author

Ah, that makes sense -- thanks for the pointer. It'll probably be towards the end of the week, but I can definitely make that work.

@jneilliii
Copy link
Contributor

sounds good. just ping me back when you are ready. feel free to update the release date in your template as well when the time is right.

@MoltenBytes
Copy link
Contributor Author

Alright, this should be good to go now! I said it before, but thanks again for that link reference. Not sure I'd have figured out gitlab's archive URL without it. Plugin should support software updates from Gitlab via python now 👍

Not sure which template you were wanting me to update the release date for.

@jneilliii jneilliii merged commit 6978ab2 into OctoPrint:gh-pages Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants