-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plugin InfluxDB2 #1163
Added plugin InfluxDB2 #1163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only see one change that I would request prior to merging this into the plugin repo. Your plugin is missing a software update hook, which would allow for your users to automatically get update notifications on new releases. You can find the docs for this here. I can't say I remember another GitLab example of this but will try to find one for you.
The only other GitLab example of a plugin update I could find actually utilizes PyPi release updates. I'm sure there's a way to do it similar to the GitHub version without PyPi releases, just don't have an example for you. https://gitlab.com/wolframmfg/octoprint-swapxy/-/blob/main/octoprint_swapxy/__init__.py#L17 |
I think I got it -- gitlab doesn't have native support, but I was able to make it work with
If you want to test it, you can install the package from v0.1.2 here and it should prompt and successfully update to v0.1.3 |
Test worked as expected, only downside to the commandline update method though means os compatibility needs to be flagged now to linux only in your plugin template. |
I remembered where I've seen GitLab update before. It was with my palette and it's related plugins. https://gitlab.com/mosaic-mfg/palette-2-plugin/-/blob/master/octoprint_palette2/__init__.py |
Ah, that makes sense -- thanks for the pointer. It'll probably be towards the end of the week, but I can definitely make that work. |
sounds good. just ping me back when you are ready. feel free to update the release date in your template as well when the time is right. |
Alright, this should be good to go now! I said it before, but thanks again for that link reference. Not sure I'd have figured out gitlab's archive URL without it. Plugin should support software updates from Gitlab via python now 👍 Not sure which template you were wanting me to update the release date for. |
Here's the link to the new plugin
Not sure what else I can say that hasn't already been said in these documents or back on the homepage 😅