-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Abandoned Plugin] MarlinGcodeDocumentation #1347
Comments
I'll give the plugin author one more week to respond to the issue posted on their repo, but yes looks to be abandoned. |
Hi @jneilliii 👋 I don't know what it takes to maintain an Octoprint plugin, but I find this one very useful, so I'll read some docs and maybe I'll raise my hand to take over as maintainer :) |
I must say I personally also find this plugin super useful. Wouldn't mind helping maintaining. |
It seems that plugin generates machine-readable docs here So basically you need to fork their repos and set up documentation generator via github actions or something else that periodically updates data. There could be issues caused by marlin changing documentation format so this must be fixed too. |
yeah, looking at the plugin code, it seems to already have a documentation update mechanism and with settings to pull from |
I've forked the gcode-documentation-parser repo here, and refreshed it a bit :
The generated documentation seems coherent to me. |
Works pretty well actually, I fed the plugin with my fork's output, here's what it gives for a command that's part of the last commit of my output branch : |
Was going to test out your export, but I can't seem to get the plugin to load at all with default settings with the following error in browser's developer tools. Issue was related to not having the js bundled I think. Once I removed the following from my config.yaml it loads fine.
plugin doesn't like windows instances at all, when attempting to update it gives errors. if someone does adopt this plugin it might be something to add to the list of issues.
I'd also switch this bit of js self.onUpdateDocumentation = async function () {
var response = await fetch("/api/plugin/marlingcodedocumentation", {
method: "POST",
headers: {
"Content-Type": "application/json",
"X-Api-Key": self.settingsViewModel.api_key()
},
body: JSON.stringify({
command: "update-documentation"
})
});
if (!response.ok) {
return;
}
var newData = await response.json();
if (!newData) {
return;
}
self.documentationService.update(newData);
}; with self.onUpdateDocumentation = function () {
OctoPrint.simpleApiCommand("marlingcodedocumentation", "update-documentation", {}})
.done(function (data) {
if (!data) {
return;
}
self.documentationService.update(data);
});
}; to avoid 403 forbidden errors. |
I didn't have a look at the plugin itself yet, only the gcode parser. I intended do dig into it asap. I'm not very comfortable with javascript and frontend stuff in general, but that might be a good opportunity to improve myself. I'll do the same as for the gcode parser, fork the repo, and spend some time playing with it. |
Which Plugin?
https://plugins.octoprint.org/plugins/marlingcodedocumentation/
Link to ticket on plugin's issue tracker confirming abandonment
costas-basdekis/MarlinGcodeDocumentation#25
Is there someone open to adopting it?
No response
The text was updated successfully, but these errors were encountered: