[Abandoned Plugin] OctoPrint-Webhooks

[derekantrican]

Which Plugin?

https://plugins.octoprint.org/plugins/webhooks

Link to ticket on plugin's issue tracker confirming abandonment

2blane/OctoPrint-Webhooks#38

Is there someone open to adopting it?

@derekantrican

[jneilliii]

@derekantrican since you already have a fork it's just a matter of updating the plugin listing page to point to yours and add you to the authors list. Make sure to change the software update hook to point to your repo and bump the version and release with the new version number. If you need any pointers, I'd look at this adoption PR as reference of what they changed as part of the process, and don't hesitate to ask any questions for clarification.

#1027

[derekantrican]

Thanks! I'll make sure I move my pending changes to a different branch so the "master" mirrors the current state of the official repo.

Once I've updated the update hook (and anything else) do I just come back here and give you the "go ahead" to update the plugin listing page?

[jneilliii]

Submit a PR similar to the one above referencing this issue.

[derekantrican]

@jneilliii Thanks! At what point can I expect this to show up on plugins.octoprint.org and (nvm - looks like that's already been updated) the alert to users in their octoprint interface?

[jneilliii]

It typically is within 24 hours, but that depends on the user's configured TTL for plugin update notices.

[derekantrican]

@jneilliii I got the notifications on my octoprint instance today (both the "new maintainer" notice and the notification of update available). Out of curiosity I clicked the "Update" button in the notification for the new version and it failed (probably expectedly as the old plugin is still pointing at the old repo and the new version doesn't exist at that repo - hence the notice to uninstall & reinstall).

Is there a chance Octoprint could have a "migrate & update" sort of feature for this case where the plugin has moved repos? Or perhaps a "uninstall & reinstall" option if the plugin fails to update?

[cp2004]

The pip field must also be specified in the overlays file here:

plugins.octoprint.org/_data/update_check_overlays.yaml

Lines 52 to 53 in 05874cb

	webhooks:
	user: derekantrican

Similar to this, it overrides the pip field in the SW update config, so it should look the same as what you have the SW update hook looking like at the moment.

plugins.octoprint.org/_data/update_check_overlays.yaml

Lines 45 to 47 in 05874cb

	ledstripcontrol:
	user: gbonesso
	pip: https://github.com/gbonesso/OctoPrint-LEDStripControl/archive/{target_version}.zip

[derekantrican]

Thank you! I'll make that change

[jneilliii]

Ah, thanks for the clarification @cp2004. I thought updating the user alone was enough to handle the redirect.