From ced6aee99fb7fa980af1fa65cbd522093159e07b Mon Sep 17 00:00:00 2001
From: Leonardo Mendoza Fernadez <l.mendoza@Leonardos-MacBook-Pro.local>
Date: Wed, 20 Mar 2024 15:48:56 -0600
Subject: [PATCH] batch-fixes-mar-20-2024

---
 src/app/authorize/pages/authorize/authorize.component.html   | 4 ++--
 src/app/cdk/my-orcid-alerts/my-orcid-alerts.component.html   | 5 +++--
 .../component/trusted-summary/trusted-summary.component.scss | 4 ++--
 .../trusted-summary.component.scss-theme.scss                | 4 ++--
 .../errors/print-errors/print-errors.component.html          | 2 +-
 .../components/form-sign-in/form-sign-in.component.html      | 3 ---
 src/app/sign-in/pages/sign-in/sign-in.component.html         | 1 -
 7 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/src/app/authorize/pages/authorize/authorize.component.html b/src/app/authorize/pages/authorize/authorize.component.html
index f97a218754..1fde0069a5 100644
--- a/src/app/authorize/pages/authorize/authorize.component.html
+++ b/src/app/authorize/pages/authorize/authorize.component.html
@@ -1,4 +1,4 @@
-<main id="main">
+<main id="main" *ngIf="!loading">
   <div class="container">
     <div class="row space-around">
       <div
@@ -18,7 +18,7 @@
         >
           <app-form-authorize
             [signInUpdatesV1Togglz]="signInUpdatesV1Togglz"
-            *ngIf="showAuthorizationComponent && !loading"
+            *ngIf="showAuthorizationComponent"
           ></app-form-authorize>
           <app-oauth-error
             *ngIf="!showAuthorizationComponent"
diff --git a/src/app/cdk/my-orcid-alerts/my-orcid-alerts.component.html b/src/app/cdk/my-orcid-alerts/my-orcid-alerts.component.html
index f4598ebc5e..559dead970 100644
--- a/src/app/cdk/my-orcid-alerts/my-orcid-alerts.component.html
+++ b/src/app/cdk/my-orcid-alerts/my-orcid-alerts.component.html
@@ -1,7 +1,7 @@
 <ng-container *ngIf="!signInUpdatesV1Togglz">
   <mat-toolbar>
     <mat-toolbar-row>
-      <div role="alert">
+      <div role="alert" aria-label="polite">
         <p class="mat-body-2">
           <ng-container
             i18n="@@myOrcidAlerts.invalidVerifyUrl"
@@ -24,6 +24,7 @@
 <ng-container *ngIf="signInUpdatesV1Togglz">
   <ng-container *ngIf="emailVerified || invalidVerifyUrl">
     <div
+    aria-label="polite"
       [ngClass]="{
         verification: emailVerified,
         invalid: invalidVerifyUrl
@@ -58,7 +59,7 @@
     </div>
   </ng-container>
   <ng-container *ngIf="printError && badCredentials">
-    <div class="invalid">
+    <div class="invalid" aria-label="polite">
       <div>
         <mat-icon class="large-material-icon material-symbols-outlined"
           >warning</mat-icon
diff --git a/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss b/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss
index f6f05059ba..45160d9538 100644
--- a/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss
+++ b/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss
@@ -91,7 +91,7 @@ main.inside-iframe {
   border-right: 2px solid;
 }
 
-h2 {
+h3 {
   font-weight: 600;
   letter-spacing: 2px;
 }
@@ -201,7 +201,7 @@ a {
     gap: 8px;
   }
 
-  h2.hover-effect {
+  h3.hover-effect {
     text-decoration: underline;
   }
 }
diff --git a/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss-theme.scss b/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss-theme.scss
index cee6f58456..f8e635ad0d 100644
--- a/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss-theme.scss
+++ b/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss-theme.scss
@@ -9,7 +9,7 @@
   $background: map-get($theme, background);
 
   a {
-    h2.hover-effect {
+    h3.hover-effect {
       color: mat.get-color-from-palette($primary, 500);
     }
 
@@ -17,7 +17,7 @@
       color: #fff;
     }
 
-    h2 {
+    h3 {
       color: black;
     }
   }
diff --git a/src/app/sign-in/components/errors/print-errors/print-errors.component.html b/src/app/sign-in/components/errors/print-errors/print-errors.component.html
index 397ebdb8fc..87415ce666 100644
--- a/src/app/sign-in/components/errors/print-errors/print-errors.component.html
+++ b/src/app/sign-in/components/errors/print-errors/print-errors.component.html
@@ -38,7 +38,7 @@
   </mat-error>
 </ng-container>
 <ng-container *ngIf="signInUpdatesV1Togglz">
-  <div class="info">
+  <div class="info" aria-live="polite">
     <div>
       <mat-icon class="large-material-icon material-symbols-outlined"
         >error</mat-icon
diff --git a/src/app/sign-in/components/form-sign-in/form-sign-in.component.html b/src/app/sign-in/components/form-sign-in/form-sign-in.component.html
index e699ee0ad5..36f2f83c4f 100644
--- a/src/app/sign-in/components/form-sign-in/form-sign-in.component.html
+++ b/src/app/sign-in/components/form-sign-in/form-sign-in.component.html
@@ -69,7 +69,6 @@
       [signInUpdatesV1Togglz]="signInUpdatesV1Togglz"
       [printError]="printError"
       [badCredentials]="badCredentials"
-      [attr.aria-live]="'polite'"
     ></app-my-orcid-alerts>
     <div class="input-container">
       <mat-label
@@ -195,13 +194,11 @@
     [showInvalidUser]="showInvalidUser"
     [orcidPrimaryDeprecated]="orcidPrimaryDeprecated"
     [email]="email"
-    [attr.aria-live]="'polite'"
   >
   </app-print-errors>
   <app-deactivated
     *ngIf="!signInUpdatesV1Togglz && showDeactivatedError"
     [email]="email"
-    [attr.aria-live]="'polite'"
   >
   </app-deactivated>
   <app-two-factor-authentication-form
diff --git a/src/app/sign-in/pages/sign-in/sign-in.component.html b/src/app/sign-in/pages/sign-in/sign-in.component.html
index e03b3f8fec..b71372efae 100644
--- a/src/app/sign-in/pages/sign-in/sign-in.component.html
+++ b/src/app/sign-in/pages/sign-in/sign-in.component.html
@@ -3,7 +3,6 @@
     *ngIf="!signInUpdatesV1Togglz && (emailVerified || invalidVerifyUrl)"
     [emailVerified]="emailVerified"
     [invalidVerifyUrl]="invalidVerifyUrl"
-    [attr.aria-live]="'polite'"
   ></app-my-orcid-alerts>
   <div class="container">
     <div class="row space-around">