From 36e643df1936af45bd01fc32bec28125800c2b80 Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Date: Wed, 5 Jul 2023 16:49:25 -0600 Subject: [PATCH 1/8] 8712-qa-developer-tools-mobile-issues --- .../developer-tools.component.html | 18 +++++++----- .../developer-tools.component.scss | 28 +++++++++++++++++++ .../developer-tools.component.ts | 13 ++++++++- 3 files changed, 51 insertions(+), 8 deletions(-) diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html index 76ce022153..b7d91da5a8 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html @@ -85,7 +85,11 @@ >Application name - + - - +
>delete - - +
+
id="cy-register-for-public-api" (click)="save()" [disabled]="form.pristine" - class="save-button" + class="save-button mat-button-wrap-text" > Save application and generate my client ID and secret diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.scss b/src/app/developer-tools/pages/developer-tools/developer-tools.component.scss index 032682f464..6cc8a6bf49 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.scss +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.scss @@ -150,6 +150,7 @@ app-client-secret { .save-button { margin-top: 32px; + margin-bottom: 32px; } .save-message { @@ -158,3 +159,30 @@ app-client-secret { margin-top: 32px; margin-bottom: 0; } + + +.input-container { + display: flex; + flex-direction: column; + width: 100%; + + .input-group { + display: flex; + flex-direction: row; + + .mat-icon-button { + top: -5px; + } + } + + +} + + +.columns-8 :host, +.columns-4 :host { + .title-container { + flex-direction: column; + align-items: flex-start; + } +} \ No newline at end of file diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.ts b/src/app/developer-tools/pages/developer-tools/developer-tools.component.ts index 9432eb5f9f..16cdaf6a94 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.ts +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.ts @@ -34,6 +34,7 @@ import { RecordService } from 'src/app/core/record/record.service' import { MatInput } from '@angular/material/input' import { environment } from 'src/environments/environment' import { WINDOW } from 'src/app/cdk/window' +import { PlatformInfoService } from 'src/app/cdk/platform-info' @Component({ selector: 'app-developer-tools', @@ -63,6 +64,8 @@ export class DeveloperToolsComponent implements OnInit, OnDestroy { sucessSave: boolean loadingUserDevTolsState: boolean baseURL: string + isMobile: boolean + @ViewChild('firstInput') firstInput: ElementRef constructor( @@ -72,7 +75,8 @@ export class DeveloperToolsComponent implements OnInit, OnDestroy { private matDialog: MatDialog, private recordService: RecordService, private _changeDetectorRef: ChangeDetectorRef, - @Inject(WINDOW) private window: Window + @Inject(WINDOW) private window: Window, + private _platform: PlatformInfoService ) {} ngOnDestroy(): void { this.destroy$.next(true) @@ -80,6 +84,13 @@ export class DeveloperToolsComponent implements OnInit, OnDestroy { } ngOnInit(): void { + this._platform + .get() + .pipe(takeUntil(this.destroy$)) + .subscribe((platform) => { + this.isMobile = platform.columns4 || platform.columns8 + }) + this.baseURL = this.window.location.origin this.getDeveloperToolsEnableState() .pipe( From 06dbed83fa02b8ba15c1e7420a089aa3ef4e1a68 Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Date: Wed, 5 Jul 2023 16:51:48 -0600 Subject: [PATCH 2/8] 8713-qa-typos-in-developer-tools --- .../components/code-panel/code-panel.component.ts | 2 +- .../pages/developer-tools/developer-tools.component.html | 6 +++--- .../developer-tools/developer-tools.en.properties | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/app/developer-tools/components/code-panel/code-panel.component.ts b/src/app/developer-tools/components/code-panel/code-panel.component.ts index a35b8f1ecd..3122b69e59 100644 --- a/src/app/developer-tools/components/code-panel/code-panel.component.ts +++ b/src/app/developer-tools/components/code-panel/code-panel.component.ts @@ -11,7 +11,7 @@ import { Component, Input, OnInit } from '@angular/core' export class CodePanelComponent implements OnInit { collapseAriaLabel = $localize`:@@developerTools.collapse:Collapse` expandAriaLabel = $localize`:@@developerTools.expand:Expand` - exampleCodeAriaLabel = $localize`:@@developerTools.exampleCode:example code` + exampleCodeAriaLabel = $localize`:@@developerTools.exampleCode2:example code` openState = false @Input() title: string diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html index b7d91da5a8..f8c571d7c1 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html @@ -347,7 +347,7 @@

access token and an authenticated ORCID iD.

- Ednpoint + Endpoint

{{ baseURL }}/oauth/authorize

Scope @@ -373,7 +373,7 @@

be used to read public information on the record.

- Ednpoint + Endpoint

{{ baseURL }}/oauth/token

>

- Ednpoint + Endpoint

{{ baseURL }}/oauth/token

Scope diff --git a/src/locale/properties/developer-tools/developer-tools.en.properties b/src/locale/properties/developer-tools/developer-tools.en.properties index a82ff24260..100ee8178f 100644 --- a/src/locale/properties/developer-tools/developer-tools.en.properties +++ b/src/locale/properties/developer-tools/developer-tools.en.properties @@ -52,7 +52,7 @@ developerTools.changesHaveBeenSavedSuccessfully=Changes have been saved successf developerTools.saveApplicationAndGenerate=Save application and generate my client ID and secret developerTools.saveApplication=Save application developerTools.providesAnAuthorizationCode=Provides an authorization code that can be exchanged for an access token and an authenticated ORCID iD. -developerTools.endpoint=Ednpoint +developerTools.endpoint=Endpoint developerTools.scope=Scope developerTools.code=code developerTools.providesAnAuthenticatd=Provides an authenticated ORCID iD and an access token that can be used to read public information on the record. @@ -75,4 +75,4 @@ developerTools.expand=Expand developerTools.replaceWithRedirect=REPLACE WITH REDIRECT URI developerTools.replaceWithOauth=REPLACE WITH OAUTH CODE developerTools.backToMyRecod=Back to my record -developerTools.exampleCode=example code +developerTools.exampleCode2=example code From 0310f5cf586c18af664d35b6fe6987b0db1d552b Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Date: Wed, 5 Jul 2023 17:00:50 -0600 Subject: [PATCH 3/8] Fix --- .../pages/developer-tools/developer-tools.component.html | 7 ++----- .../pages/developer-tools/developer-tools.component.ts | 6 ++++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html index f8c571d7c1..372473d0f8 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html @@ -2,7 +2,7 @@
-
+

Back to my record @@ -463,9 +462,7 @@

[disabled]="form.pristine" class="save-button mat-button-wrap-text" > - + Save application and generate my client ID and secret diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.ts b/src/app/developer-tools/pages/developer-tools/developer-tools.component.ts index 16cdaf6a94..1eb91b2c1b 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.ts +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.ts @@ -35,6 +35,7 @@ import { MatInput } from '@angular/material/input' import { environment } from 'src/environments/environment' import { WINDOW } from 'src/app/cdk/window' import { PlatformInfoService } from 'src/app/cdk/platform-info' +import { log } from 'console' @Component({ selector: 'app-developer-tools', @@ -66,7 +67,7 @@ export class DeveloperToolsComponent implements OnInit, OnDestroy { baseURL: string isMobile: boolean - @ViewChild('firstInput') firstInput: ElementRef + @ViewChild('firstInput') mainElement: ElementRef constructor( private fb: FormBuilder, @@ -141,7 +142,8 @@ export class DeveloperToolsComponent implements OnInit, OnDestroy { }) this._changeDetectorRef.detectChanges() - this.firstInput.nativeElement.focus() + console.log('......... ', this.mainElement) + this.mainElement.nativeElement.focus() } save() { From f521674dcd864e403ea2607a698490a9f016a329 Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Date: Wed, 5 Jul 2023 17:01:54 -0600 Subject: [PATCH 4/8] revert focus item --- .../pages/developer-tools/developer-tools.component.html | 3 ++- .../pages/developer-tools/developer-tools.component.ts | 6 ++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html index 372473d0f8..9fd7caf47e 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html @@ -2,7 +2,7 @@
-
+

Date: Wed, 5 Jul 2023 17:03:30 -0600 Subject: [PATCH 5/8] Remove testing code --- .../pages/developer-tools/developer-tools.component.html | 1 + 1 file changed, 1 insertion(+) diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html index 9fd7caf47e..32cb1cda5a 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html @@ -439,6 +439,7 @@

Changes have been saved successfully. From 8b6ae7ae8eed610a0104400b7fda83f8859d090e Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Date: Wed, 5 Jul 2023 17:04:34 -0600 Subject: [PATCH 6/8] Remove testing code --- .../pages/developer-tools/developer-tools.component.html | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html index 32cb1cda5a..b6c1322401 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html @@ -439,7 +439,6 @@

Changes have been saved successfully. @@ -464,7 +463,11 @@

[disabled]="form.pristine" class="save-button mat-button-wrap-text" > - + Save application and generate my client ID and secret From 89937e3c0e1e556ddf1e75558ab8d40cd53b4904 Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Date: Wed, 5 Jul 2023 20:29:23 -0600 Subject: [PATCH 7/8] fix testing --- .../pages/developer-tools/developer-tools.component.spec.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.spec.ts b/src/app/developer-tools/pages/developer-tools/developer-tools.component.spec.ts index 1d81c9c163..52ce3e00aa 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.spec.ts +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.spec.ts @@ -9,6 +9,7 @@ import { UserInfoService } from 'src/app/core/user-info/user-info.service' import { of } from 'rxjs' import { WINDOW_PROVIDERS } from 'src/app/cdk/window' import { DeveloperToolsComponent } from './developer-tools.component' +import { PlatformInfoService } from 'src/app/cdk/platform-info' describe('DeveloperToolsComponent', () => { let component: DeveloperToolsComponent @@ -19,6 +20,10 @@ describe('DeveloperToolsComponent', () => { declarations: [DeveloperToolsComponent], providers: [ WINDOW_PROVIDERS, + { + provide: PlatformInfoService, + useValue: { get: () => of({}) }, + }, { provide: FormBuilder, useValue: {}, From 70dabe9a9f093b1874754063aedd045ae564b5e6 Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Date: Wed, 5 Jul 2023 20:36:28 -0600 Subject: [PATCH 8/8] fix i18n --- src/app/cdk/platform-info/browserlist.regexp.ts | 3 +-- .../properties/developer-tools/developer-tools.en.properties | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/app/cdk/platform-info/browserlist.regexp.ts b/src/app/cdk/platform-info/browserlist.regexp.ts index dd011b22dc..954be17405 100644 --- a/src/app/cdk/platform-info/browserlist.regexp.ts +++ b/src/app/cdk/platform-info/browserlist.regexp.ts @@ -1,3 +1,2 @@ // tslint:disable-next-line: max-line-length -export const BROWSERLIST_REGEXP = - /((CPU[ +]OS|iPhone[ +]OS|CPU[ +]iPhone|CPU IPhone OS)[ +]+(13[_.]4|13[_.]([5-9]|\d{2,})|13[_.]7|13[_.]([8-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})[_.]\d+|14[_.]0|14[_.]([1-9]|\d{2,})|14[_.]4|14[_.]([5-9]|\d{2,})|14[_.]8|14[_.](9|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})[_.]\d+|15[_.]0|15[_.]([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})[_.]\d+|16[_.]0|16[_.]([1-9]|\d{2,})|(1[7-9]|[2-9]\d|\d{3,})[_.]\d+)(?:[_.]\d+)?)|((?:Chrome).*OPR\/(74|(7[5-9]|[8-9]\d|\d{3,}))\.\d+\.\d+)|(Edge\/(80|(8[1-9]|9\d|\d{3,})|83|(8[4-9]|9\d|\d{3,}))(?:\.\d+)?)|((Chromium|Chrome)\/(80|(8[1-9]|9\d|\d{3,})|83|(8[4-9]|9\d|\d{3,}))\.\d+(?:\.\d+)?)|(Version\/(13\.1|13\.([2-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})\.\d+|14\.0|14\.([1-9]|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})\.\d+|15\.0|15\.([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})\.\d+|16\.0|16\.([1-9]|\d{2,})|(1[7-9]|[2-9]\d|\d{3,})\.\d+)(?:\.\d+)? Safari\/)|(Firefox\/(78|(79|[8-9]\d|\d{3,}))\.\d+\.\d+)|(Firefox\/(78|(79|[8-9]\d|\d{3,}))\.\d+(pre|[ab]\d+[a-z]*)?)/ +export const BROWSERLIST_REGEXP = /((CPU[ +]OS|iPhone[ +]OS|CPU[ +]iPhone|CPU IPhone OS)[ +]+(13[_.]4|13[_.]([5-9]|\d{2,})|13[_.]7|13[_.]([8-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})[_.]\d+|14[_.]0|14[_.]([1-9]|\d{2,})|14[_.]4|14[_.]([5-9]|\d{2,})|14[_.]8|14[_.](9|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})[_.]\d+|15[_.]0|15[_.]([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})[_.]\d+|16[_.]0|16[_.]([1-9]|\d{2,})|(1[7-9]|[2-9]\d|\d{3,})[_.]\d+)(?:[_.]\d+)?)|((?:Chrome).*OPR\/(74|(7[5-9]|[8-9]\d|\d{3,}))\.\d+\.\d+)|(Edge\/(80|(8[1-9]|9\d|\d{3,})|83|(8[4-9]|9\d|\d{3,}))(?:\.\d+)?)|((Chromium|Chrome)\/(80|(8[1-9]|9\d|\d{3,})|83|(8[4-9]|9\d|\d{3,}))\.\d+(?:\.\d+)?)|(Version\/(13\.1|13\.([2-9]|\d{2,})|(1[4-9]|[2-9]\d|\d{3,})\.\d+|14\.0|14\.([1-9]|\d{2,})|(1[5-9]|[2-9]\d|\d{3,})\.\d+|15\.0|15\.([1-9]|\d{2,})|(1[6-9]|[2-9]\d|\d{3,})\.\d+|16\.0|16\.([1-9]|\d{2,})|(1[7-9]|[2-9]\d|\d{3,})\.\d+)(?:\.\d+)? Safari\/)|(Firefox\/(78|(79|[8-9]\d|\d{3,}))\.\d+\.\d+)|(Firefox\/(78|(79|[8-9]\d|\d{3,}))\.\d+(pre|[ab]\d+[a-z]*)?)/ diff --git a/src/locale/properties/developer-tools/developer-tools.en.properties b/src/locale/properties/developer-tools/developer-tools.en.properties index d8fe254e54..19f2984f3e 100644 --- a/src/locale/properties/developer-tools/developer-tools.en.properties +++ b/src/locale/properties/developer-tools/developer-tools.en.properties @@ -61,7 +61,7 @@ developerTools.providesAnAccess=Provides an access token that can be used to rea developerTools.moreInformation=More information on OpenID Connect Endpoint developerTools.responseType=Response type developerTools.clientId=Client ID -developerTools.exampleCode=example code +developerTools.exampleCode=Example code developerTools.ariaLabelWebsiteDelete=Delete redirect URI developerTools.labelAuthorizeRequest=Authorize request developerTools.labelTokenRequest=Token request