From 186eb8349510235edf8f013a1b898e2881743369 Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Fernadez Date: Thu, 28 Nov 2024 06:29:09 -0600 Subject: [PATCH 1/3] Revert "9499-email-domains-interstitial-registry-sign-in" This reverts commit 8a4f7db0ca00e05599cea035e7922303ab253ee5. --- src/app/core/login-interstitials/login-interstitials.service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/core/login-interstitials/login-interstitials.service.ts b/src/app/core/login-interstitials/login-interstitials.service.ts index 700664b36..a63d37f44 100644 --- a/src/app/core/login-interstitials/login-interstitials.service.ts +++ b/src/app/core/login-interstitials/login-interstitials.service.ts @@ -81,4 +81,4 @@ export class LoginInterstitialsService { userHasPrivateDomains(value: EmailsEndpoint): boolean { return !!value.emailDomains.find((domain) => domain.visibility !== 'PUBLIC') } -} +} \ No newline at end of file From 50c3cc0e3fbf7f20c7c1c984e567056c90a6c927 Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Fernadez Date: Thu, 28 Nov 2024 06:32:47 -0600 Subject: [PATCH 2/3] 9522-qa-unable-to-scroll-down-inside-email-domains-interstitial-using-mobile-devices --- .../login-interstitials.service.ts | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/app/core/login-interstitials/login-interstitials.service.ts b/src/app/core/login-interstitials/login-interstitials.service.ts index a63d37f44..32cbe164b 100644 --- a/src/app/core/login-interstitials/login-interstitials.service.ts +++ b/src/app/core/login-interstitials/login-interstitials.service.ts @@ -27,7 +27,7 @@ export class LoginInterstitialsService { this.interstitialService .getInterstitialsViewed('DOMAIN_INTERSTITIAL') .subscribe((viewed) => { - this.alreadySawSignDomainInterstitial = viewed + // this.alreadySawSignDomainInterstitial = viewed }) this.toggleService .getStateOf('LOGIN_DOMAINS_INTERSTITIAL') @@ -48,10 +48,10 @@ export class LoginInterstitialsService { userRecord.userInfo.EFFECTIVE_USER_ORCID if ( - isNotImpersonating && - !this.userHasPublicDomains(userRecord.emails) && - this.userHasPrivateDomains(userRecord.emails) && - this.loginDomainsInterstitialEnabled && + // isNotImpersonating && + // !this.userHasPublicDomains(userRecord.emails) && + // this.userHasPrivateDomains(userRecord.emails) && + // this.loginDomainsInterstitialEnabled && !this.alreadySawSignDomainInterstitial ) { this.alreadySawSignDomainInterstitial = true @@ -68,6 +68,7 @@ export class LoginInterstitialsService { disableClose: true, autoFocus: false, restoreFocus: false, + maxHeight: 'calc(100vh - 20px)', }) return dialog.afterClosed() } @@ -81,4 +82,4 @@ export class LoginInterstitialsService { userHasPrivateDomains(value: EmailsEndpoint): boolean { return !!value.emailDomains.find((domain) => domain.visibility !== 'PUBLIC') } -} \ No newline at end of file +} From 45f2dc69209d059fff7970b3c268dfc3c452ba01 Mon Sep 17 00:00:00 2001 From: Leonardo Mendoza Fernadez Date: Thu, 28 Nov 2024 06:34:03 -0600 Subject: [PATCH 3/3] 9522-qa-unable-to-scroll-down-inside-email-domains-interstitial-using-mobile-devices --- .../login-interstitials/login-interstitials.service.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/app/core/login-interstitials/login-interstitials.service.ts b/src/app/core/login-interstitials/login-interstitials.service.ts index 32cbe164b..ce564e6ef 100644 --- a/src/app/core/login-interstitials/login-interstitials.service.ts +++ b/src/app/core/login-interstitials/login-interstitials.service.ts @@ -27,7 +27,7 @@ export class LoginInterstitialsService { this.interstitialService .getInterstitialsViewed('DOMAIN_INTERSTITIAL') .subscribe((viewed) => { - // this.alreadySawSignDomainInterstitial = viewed + this.alreadySawSignDomainInterstitial = viewed }) this.toggleService .getStateOf('LOGIN_DOMAINS_INTERSTITIAL') @@ -48,10 +48,10 @@ export class LoginInterstitialsService { userRecord.userInfo.EFFECTIVE_USER_ORCID if ( - // isNotImpersonating && - // !this.userHasPublicDomains(userRecord.emails) && - // this.userHasPrivateDomains(userRecord.emails) && - // this.loginDomainsInterstitialEnabled && + isNotImpersonating && + !this.userHasPublicDomains(userRecord.emails) && + this.userHasPrivateDomains(userRecord.emails) && + this.loginDomainsInterstitialEnabled && !this.alreadySawSignDomainInterstitial ) { this.alreadySawSignDomainInterstitial = true