From 34d74b79dd4fd381b8ebbdb6590f461cc5d6e4ad Mon Sep 17 00:00:00 2001 From: Daniel Palafox Date: Tue, 6 Feb 2024 20:39:03 -0500 Subject: [PATCH] fix: Remove hardcoded togglz value and fix tests --- .../record-header.component.spec.ts | 32 ++++++++++++++++--- .../record-info/record-info.component.spec.ts | 31 +++++++++++++++--- .../pages/my-orcid/my-orcid.component.ts | 3 +- 3 files changed, 56 insertions(+), 10 deletions(-) diff --git a/src/app/record/components/record-header/record-header.component.spec.ts b/src/app/record/components/record-header/record-header.component.spec.ts index 6556de88b7..60ca1a17ee 100644 --- a/src/app/record/components/record-header/record-header.component.spec.ts +++ b/src/app/record/components/record-header/record-header.component.spec.ts @@ -1,15 +1,39 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { RecordHeaderComponent } from './record-header.component'; +import { HttpClientTestingModule } from '@angular/common/http/testing'; +import { WINDOW_PROVIDERS } from 'src/app/cdk/window'; +import { PlatformInfoService } from 'src/app/cdk/platform-info'; +import { ErrorHandlerService } from 'src/app/core/error-handler/error-handler.service'; +import { SnackbarService } from 'src/app/cdk/snackbar/snackbar.service'; +import { MatLegacySnackBar as MatSnackBar } from '@angular/material/legacy-snack-bar' +import { MatLegacyDialog as MatDialog } from '@angular/material/legacy-dialog' +import { Overlay } from '@angular/cdk/overlay'; +import { RouterTestingModule } from '@angular/router/testing'; +import { RecordService } from 'src/app/core/record/record.service'; -describe('TopBarPublicNamesComponent', () => { +describe('RecordHeaderComponent', () => { let component: RecordHeaderComponent; let fixture: ComponentFixture; + beforeEach(async () => { + await TestBed.configureTestingModule({ + imports: [HttpClientTestingModule, RouterTestingModule], + declarations: [RecordHeaderComponent], + providers: [ + WINDOW_PROVIDERS, + RecordService , + PlatformInfoService, + ErrorHandlerService, + SnackbarService, + MatSnackBar, + MatDialog, + Overlay, + ], + }).compileComponents() + }) + beforeEach(() => { - TestBed.configureTestingModule({ - declarations: [RecordHeaderComponent] - }); fixture = TestBed.createComponent(RecordHeaderComponent); component = fixture.componentInstance; fixture.detectChanges(); diff --git a/src/app/record/components/record-info/record-info.component.spec.ts b/src/app/record/components/record-info/record-info.component.spec.ts index 8926ee9cd3..9ed8462152 100644 --- a/src/app/record/components/record-info/record-info.component.spec.ts +++ b/src/app/record/components/record-info/record-info.component.spec.ts @@ -1,20 +1,43 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { RecordInfoComponent } from './record-info.component'; +import { HttpClientTestingModule } from '@angular/common/http/testing'; +import { RouterTestingModule } from '@angular/router/testing'; +import { WINDOW_PROVIDERS } from 'src/app/cdk/window'; +import { PlatformInfoService } from 'src/app/cdk/platform-info'; +import { ErrorHandlerService } from 'src/app/core/error-handler/error-handler.service'; +import { SnackbarService } from 'src/app/cdk/snackbar/snackbar.service'; +import { MatLegacySnackBar as MatSnackBar } from '@angular/material/legacy-snack-bar' +import { MatLegacyDialog as MatDialog } from '@angular/material/legacy-dialog' +import { Overlay } from '@angular/cdk/overlay'; -describe('InfoComponent', () => { +describe('RecordInfoComponent', () => { let component: RecordInfoComponent; let fixture: ComponentFixture; + beforeEach(async () => { + await TestBed.configureTestingModule({ + imports: [HttpClientTestingModule, RouterTestingModule], + declarations: [RecordInfoComponent], + providers: [ + WINDOW_PROVIDERS, + PlatformInfoService, + ErrorHandlerService, + SnackbarService, + MatSnackBar, + MatDialog, + Overlay, + ], + }).compileComponents() + }) + beforeEach(() => { - TestBed.configureTestingModule({ - declarations: [RecordInfoComponent] - }); fixture = TestBed.createComponent(RecordInfoComponent); component = fixture.componentInstance; fixture.detectChanges(); }); + it('should create', () => { expect(component).toBeTruthy(); }); diff --git a/src/app/record/pages/my-orcid/my-orcid.component.ts b/src/app/record/pages/my-orcid/my-orcid.component.ts index c41e1800bb..87d51c14a2 100644 --- a/src/app/record/pages/my-orcid/my-orcid.component.ts +++ b/src/app/record/pages/my-orcid/my-orcid.component.ts @@ -70,8 +70,7 @@ export class MyOrcidComponent implements OnInit, OnDestroy { regionActivities = $localize`:@@shared.activities:Activities` readyForIndexing: boolean fragment: string - // @ todo - newRecordHeaderTogglz = true + newRecordHeaderTogglz = false constructor( _userInfoService: UserInfoService,